Mark Wu has posted comments on this change.
Change subject: hotunplug: identify a nic according to its alias
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
For me, it doesn't make sense to allow change mac before hotunplug. But it's a
good idea to identify nic by its alias since libvirt can guarantee it's unchanged even
after hotunplug and hotplug other interfaces.
--
To view, visit
http://gerrit.ovirt.org/12892
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae7619c2547d667103e33777180e01b285f4b18d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server