From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: sslutils: _compare_names: fix arg names and add tests
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/70951/5/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
PS5, Line 234: _compare_names
Here is the issue. We refere to _compare_name. whereas we have
compare_name
blechs (I missed your "i'll take over" note. be my
guest)
--
To view, visit
https://gerrit.ovirt.org/70951
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7faeaaee728da4f97aaa05fddf3ab2e418cb2c40
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes