Ayal Baron has posted comments on this change.
Change subject: Add the hostId parameter to reconstructMaster
......................................................................
Patch Set 13: (3 inline comments)
....................................................
File vdsm/storage/sp.py
Line 746: else:
You did not comment on this, do you agree? nack?
Line 750: safeLease)
it should be solved in a way that if connect is modified this is automatically modified as
well (i.e. call _connect or something)
Line 764: elif temporaryLock == False:
it would be easiest if it were "with clusteredLock" where you'd set
clusteredLock to the appropriate object before.
That way you don't need 'temporaryLock' at all.
--
To view, visit
http://gerrit.ovirt.org/5068
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If665af4ed8be9b5b53dffc7e1fc258b818bf7f98
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>