Nir Soffer has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check in prepareVolumePath
......................................................................
Patch Set 2:
I like this cleanup, assuming that this check is indeed unneeded, but it is not complete.
In vm.py we always check that deive is "disk" before calling vm.isVdsmImage().
If you want to remove the check here, remove it also in vm.py.
--
To view, visit
http://gerrit.ovirt.org/22363
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No