Nir Soffer has posted comments on this change.
Change subject: utils: Consider sleep time in deadline calculation
......................................................................
Patch Set 1:
Here uses of utils.retry with a timeout (code not using timeouts filtered out).
$ git grep utils.retry lib
lib/vdsm/libvirtconnection.py: return utils.retry(libvirtOpen, timeout=10, sleep=0.2)
lib/vdsm/supervdsm.py: utils.retry(self._manager.connect, Exception,
timeout=60, tries=3)
$ git grep utils.retry tests
tests/remoteFileHandlerTests.py: utils.retry(test, AssertionError, timeout=4,
sleep=0.1)
Some funcional tests are using utils.retry via self.retryAssert:
$ git grep -A1 retryAssert
tests/functional/networkTests.py: self.retryAssert(
tests/functional/networkTests.py- assertTestDevStatsReported, timeout=20)
--
tests/functional/networkTests.py: self.retryAssert(assertStatsInRange,
timeout=3)
tests/functional/networkTests.py-
--
tests/functional/storageTests.py: self.retryAssert(assertTaskOK, timeout=60)
tests/functional/storageTests.py-
--
tests/functional/storageTests.py: self.asserts.retryAssert(
tests/functional/storageTests.py- partial(self._assertBackendConnected,
connections),
--
tests/functional/storageTests.py: iqnDevs =
self.asserts.retryAssert(partial(self._getIqnDevs, iqns),
tests/functional/storageTests.py- timeout=30)
--
tests/functional/virtTests.py:
self.retryAssert(partial(self.assertQemuSetupComplete, vmid),
tests/functional/virtTests.py- timeout=10)
tests/functional/virtTests.py: self.retryAssert(partial(self.assertVmBooting,
vmid),
tests/functional/virtTests.py- timeout=3)
tests/functional/virtTests.py: self.retryAssert(partial(self.assertVmUp, vmid),
tests/functional/virtTests.py- timeout=10)
--
tests/functional/virtTests.py: self.retryAssert(partial(self.assertGuestUp, vmid,
targetUptime),
tests/functional/virtTests.py- timeout=math.ceil(targetUptime *
1.2))
--
tests/functional/virtTests.py: self.retryAssert(partial(self.assertVmDown, vmid),
tests/functional/virtTests.py- timeout=10)
--
tests/functional/virtTests.py:
self.retryAssert(partial(self.vdsm.hotplugNic,
tests/functional/virtTests.py-
deviceDef['hotplugNic']), timeout=10)
tests/functional/virtTests.py:
self.retryAssert(partial(self.vdsm.hotunplugNic,
tests/functional/virtTests.py-
deviceDef['hotplugNic']), timeout=10)
--
tests/functional/virtTests.py:
self.retryAssert(partial(self.vdsm.hotplugDisk,
tests/functional/virtTests.py-
deviceDef['hotplugDisk']), timeout=10)
tests/functional/virtTests.py:
self.retryAssert(partial(self.vdsm.hotunplugDisk,
tests/functional/virtTests.py-
deviceDef['hotplugDisk']), timeout=10)
--
To view, visit
https://gerrit.ovirt.org/46400
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f41c6b21e3432159c13d46cfe75d1f6236cbb8c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No