Francesco Romani has submitted this change and it was merged.
Change subject: hsm: Remove support for size in sectors as int
......................................................................
hsm: Remove support for size in sectors as int
We used to support volume size either as number of sectors using int, or
as number of bytes using a string. Engine is using size in bytes since
first git commit. Hosted engine setup is also using size in bytes. We
don't know about old code using number of sectors.
This patch removes the support for size in sectors. To prevent
incorrect usage we raise InvalidParameterException if called with an
integer.
Change-Id: I52957eec163973fd60a95a9bf523131f3c83a9da
Bug-Url:
https://bugzilla.redhat.com/1221603
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on:
https://gerrit.ovirt.org/47381
Reviewed-by: Adam Litke <alitke(a)redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-on:
https://gerrit.ovirt.org/47418
Tested-by: Freddy Rolland <frolland(a)redhat.com>
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
---
M client/vdsClient.py
M lib/vdsm/constants.py.in
M vdsm/rpc/vdsmapi-schema.json
M vdsm/storage/hsm.py
4 files changed, 12 insertions(+), 13 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Freddy Rolland: Verified
--
To view, visit
https://gerrit.ovirt.org/47418
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52957eec163973fd60a95a9bf523131f3c83a9da
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org