Mark Wu has posted comments on this change.
Change subject: confNet: ifcfg's VLAN should be set only on vlan cfg
......................................................................
Patch Set 1: I would prefer that you didn't submit this
After looking at the code, I found this problem could be cause by any wrong option
specified by the misguided script. Why do we only blacklist "VLAN"? How about
covert the BLACKLIST into WHITELIST? Actually, I am wondering if there's any option
need passthrough vdsm and be written into the the conf file. If no, we should remove the
parameter 'kwargs' from _createConfFile or even addNic, addVlan, addBonding and
addBridge.
--
To view, visit
http://gerrit.ovirt.org/7411
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2c9d6c86e73104424ca8ac901bf09e4b98a47ab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server