Change in vdsm[master]: net: modify VF MAC addresses on creation to a valid address
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: modify VF MAC addresses on creation to a valid address
......................................................................
Patch Set 28:
(3 comments)
https://gerrit.ovirt.org/#/c/71029/28//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2017-01-26 18:04:32 +0200
Line 6:
Line 7: api: modify VF MAC addresses on creation to a valid address
Line 8:
Line 9: igb driver forbids resetting VF MAC address back to 00:00:00:00:00:00,
I don't think it's the responsibility of the patch/commit
message to elabor
https://www.berrange.com/tags/commit-message/
Line 10: which was its original value. By setting the MAC addresses to a valid
Line 11: value (00:00:00:00:00:01, for example), upon restoration the previous address
Line 12: (which was set to be valid) will be accepted.
Line 13:
https://gerrit.ovirt.org/#/c/71029/28/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Line 70: time.sleep(0.5)
Line 71: udevadm.settle(timeout=10)
Line 72:
Line 73:
Line 74: def _set_valid_macs_for_igb_vfs(pci_path, numvfs):
Done
Maybe it's done, but it is not posted yet. I prefer to
have it as a follow-up, to simplify backport of the current patch. but taking this out of
api.py is a noble cause.
Line 75: """ igb driver forbids resetting VF MAC address back to
00:00:00:00:00:00,
Line 76: which was its original value. By setting the MAC addresses to a valid
Line 77: value (e.g. TARGET_MAC) upon restoration the valid address will
Line 78: be accepted.
PS28, Line 75:
Done
no it wasn't done I am afraid.
--
To view, visit https://gerrit.ovirt.org/71029
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib740d45206d41b330fd1b33f31765050cadbd679
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes