Nir Soffer has posted comments on this change.
Change subject: virt: enable libgfapi
......................................................................
Patch Set 6:
(4 comments)
https://gerrit.ovirt.org/#/c/44061/6//COMMIT_MSG
Commit Message:
Line 4: Commit: Ala Hino <ahino(a)redhat.com>
Line 5: CommitDate: 2015-07-29 17:03:43 +0300
Line 6:
Line 7: virt: enable libgfapi
Line 8:
Please add a real commit message, see my comment in one of the older versions.
Line 9: This change is based on Federico's changes:
Line 10:
https://gerrit.ovirt.org/33768/
Line 11:
Line 12: Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
https://gerrit.ovirt.org/#/c/44061/6/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 313
Line 314
Line 315
Line 316
Line 317
Lets move this to the else: part of the disk type == network check.
Line 320: drive['volumeChain'] = res['imgVolumesInfo']
Line 321: drive['volumeInfo'] = res['info']
Line 322: if drive.get('diskType') == DISK_TYPE.NETWORK:
Line 323: volinfo = res ['info']
Line 324: volPath = volinfo['path']
We are overriding what we did in line 318 - better set this explicitly:
if disk type is network:
volpath = volinfo['path']
...
else:
volpath = res['path']
volpath is the result of this function, so want to make it more clear when we set it.
Line 325: drive['protocol'] = volinfo['protocol']
Line 326: # currently, single host is provided due to this bug:
Line 327: #
https://bugzilla.redhat.com/1247521
Line 328: drive['hosts'] = [volinfo['hosts'][0]]
https://gerrit.ovirt.org/#/c/44061/6/vdsm/storage/glusterVolume.py
File vdsm/storage/glusterVolume.py:
Line 57: for brick in volInfo[volname]['bricks']]
Line 58:
Line 59: return {'path': glusterPath,
Line 60: 'protocol': 'gluster',
Line 61: 'volfileServer': volfileServer,
any reason to keep this? see my comment in the previous version.
--
To view, visit
https://gerrit.ovirt.org/44061
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes