Adam Litke has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.connect
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/59702/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
PS2, Line 5616: active: The domain is attached to a Storage Pool and is activated
: attached: The domain is attached to a Storage Pool but is
: deactivated
: unattached: The domain is not attached to a Storage Pool
: unknown: The status of the Storage Domain is not known
Did you verify that these are passed and returned as lowercase values? From my reading of
the code these values are capitalized :( Very unfortunate.
--
To view, visit
https://gerrit.ovirt.org/59702
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19b6f25c17e697702ec61eba6b11f256c1df4d83
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes