Adam Litke has posted comments on this change.
Change subject: dump the core of a VM
......................................................................
Patch Set 14: Code-Review-1
(1 comment)
I propose some changes to the vdsm API for this command.
....................................................
File vdsm_api/vdsmapi-schema.json
Line 5549: #
Line 5550: ##
Line 5551: {'command': {'class': 'VM', 'name':
'coreDump'},
Line 5552: 'data': {'to': 'str', 'params':
'DumpParams'}}
Line 5553:
I don't see any value in wrapping some parameters into a params dict while leaving the
'to' param on the command line. How about specifying all arguments to the command
directly:
{'command': {'class': 'VM', 'name': 'coreDump'},
5552 + 'data': {'to': 'str', 'post-action':
'CoreDumpPostAction', 'flags': 'CoreDumpFlags'}}
Line 5554: ##
Line 5555: # @VM.monitorCommand:
Line 5556: #
Line 5557: # Send a command to the qemu monitor.
--
To view, visit
http://gerrit.ovirt.org/7329
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes