Francesco Romani has posted comments on this change.
Change subject: dump the core of a VM
......................................................................
Patch Set 18:
(2 comments)
http://gerrit.ovirt.org/#/c/7329/18/vdsm/API.py
File vdsm/API.py:
Line 286: 'message': msg}}
Line 287: self.log.error(msg)
Line 288: return error
Line 289:
Line 290: if postAction and postAction not in ("live",
"crash", "reset"):
Some constants would be better here instead of plain strings.
Moreover, just checking
if postAction not in ("live", ...):
should be enough
Line 291: msg = "Invalid value '%s' for postAction" %
postAction
Line 292: return reportError(msg)
Line 293:
Line 294: v = self._cif.vmContainer.get(self._UUID)
http://gerrit.ovirt.org/#/c/7329/18/vdsm/vm.py
File vdsm/vm.py:
Line 481: return error
Line 482:
Line 483: try:
Line 484: self.log.debug("About to perform core dump")
Line 485: if self._vm._dom is None:
How can we end up with self._vm._dom set to None?
Is this just defensive programming or there is another reason?
Line 486: raise RuntimeError('noVM')
Line 487: self._vm._dom.coreDump(self.dumpfile, self.flags)
Line 488: self.status = {'code': CoreDumpThread.Status.FINISHED,
Line 489: 'message': 'The operation is
finished'}
--
To view, visit
http://gerrit.ovirt.org/7329
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes