Sergey Gotliv has uploaded a new change for review. Change subject: sp: Remove redundant validation ...................................................................... sp: Remove redundant validation Before deactivating storage domain we validate that this domain is a member of the pool. It seems that we performed that validation twice, first time by calling validatePoolSD and second time by checking in the list of the pooled domains. Change-Id: I7bd94c40655c08ace5262d39b3087edc542f94b1 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com&gt; --- M vdsm/storage/sp.py 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/24453/1 diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index a020e1e..638dfc7 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -1052,10 +1052,6 @@ self.validatePoolSD(sdUUID) self.log.info("sdUUID=%s spUUID=%s newMsdUUID=%s", sdUUID, self.spUUID, newMsdUUID) - domList = self.getDomains() - - if sdUUID not in domList: - raise se.StorageDomainNotInPool(self.spUUID, sdUUID) try: dom = sdCache.produce(sdUUID) @@ -1095,6 +1091,7 @@ self.log.error("Can't umount masterDir %s for domain " "%s", masterDir, dom) + domList = self.getDomains() domList[sdUUID] = sd.DOM_ATTACHED_STATUS self._backend.setDomainsMap(domList) self.updateMonitoringThreads() -- To view, visit http://gerrit.ovirt.org/24453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7bd94c40655c08ace5262d39b3087edc542f94b1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com&gt;