Change in vdsm[master]: sp: Remove redundant validation
Nir Soffer has posted comments on this change.
Change subject: sp: Remove redundant validation
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24453/1/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 1054
Line 1055
Line 1056
Line 1057
Line 1058
This ineed looks redundant, but the exception raised by validatePoolSD is
se.StorageDomainNotMemberOfPool, while this code raises se.StorageDomainNotInPool.
Can you check which exception is expected by engine in this case?
Looks like we have also redundant exceptions here.
--
To view, visit http://gerrit.ovirt.org/24453
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bd94c40655c08ace5262d39b3087edc542f94b1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes