----- "James Laska" <jlaska(a)redhat.com> wrote:
On Tue, 2009-12-15 at 09:07 -0500, Kamil Paral wrote:
> ----- "James Laska" <jlaska(a)redhat.com> wrote:
>
> > From: James Laska <jlaska(a)flatline.(none)>
> >
> > ---
> > tests/rpmguard/rpmguard.py | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/tests/rpmguard/rpmguard.py
b/tests/rpmguard/rpmguard.py
> > index 2beab31..e5056a6 100644
> > --- a/tests/rpmguard/rpmguard.py
> > +++ b/tests/rpmguard/rpmguard.py
> > @@ -1,4 +1,3 @@
> > -#!/usr/bin/env python
> > # -*- coding: utf-8 -*-
> > #
> > # Copyright 2009, Red Hat, Inc.
> > --
> > 1.6.5.2
> >
>
> I'm sorry, I don't get it. What's wrong on the first line and what
> connection does it have to rpmlint?
It's just something that needs cleaning up (or an explanation) before
going through Fedora package review. If a file header contains
"#!/usr/bin/something" it's expected that it should be flagged as an
executable script in the package. Otherwise, rpmlint will provide an
error as below:
autoqa.noarch: E:
non-executable-script
/usr/share/autotest/client/site_tests/rpmguard/rpmguard.py 0644
/usr/bin/env
Oh, I didn't know that.
So you can either fix it by making the script executable, or removing
the header. In this case, and in my understanding, the script is
meant
to be included or imported and not called directly. So removing the
header seemed most appropriate.
Thanks, committed!
Hope that helps.
Thanks,
James
_______________________________________________
autoqa-devel mailing list
autoqa-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/autoqa-devel