Re: Please reconsider disabling check for mock group
On 02/07/2013 07:19 PM, Mikolaj Izdebski wrote:
>> I've implemented the mock --shell 'echo foo' test
in
>> ticket-78-test-fix branch.
>> Would be nice if we could verify that is what we want to do. But it
>> seems to
>> work pretty fine with my testing.
> This approach won't work. If mock root is clean then mock shell will
> fail.
There is a trivial, self-explanatory, non-disruptive, easily testable
solution I already proposed: skip mock check if a command line option is
given. This is quite common in design of many CLI tools to have some kind
f-r's
problem is not a shortage of options... That said, if mock root is
clean it must be inited, sooner or later. So, check becomes:
- if in mock group -> OK (fast, for most users)
- if mock echo foo works -> OK
- mock -- init works -> OK
fail
Which should make all happy, even me who tries to avoid more options if
possible ?
--alec