Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457955
Ankur Sinha sanjay_ankur@yahoo.co.in changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(sanjay_ankur@yaho | |o.co.in) |
--- Comment #4 from Ankur Sinha sanjay_ankur@yahoo.co.in 2008-10-27 08:52:34 EDT --- (In reply to comment #3)
Ok, I'll take this review
- Please do not use 69bonvenocf-fonts as package name. Use bonvenocf-fonts or
cf-bonveno-fonts (cf-bonveno-fonts is probably better as it will give you a Crude Factory prefix to use with other Crude Factory fonts)
- Please use install -dm 755 instead of mkdir as suggested by the official
spec template
You can remove the "for example" comment
69 is a bit low as fontconfig prefix, 64 is probably sufficient for a latin
font
Use 1.1 as version since upstream provides a nicely versionned archive
Since upstream provides sfd sources, please build the ttf from source using
fontforge. You have an example of sfd building in bug #467507 for example
the font is GPLv2 + font exception (cf README)
Why do you want to disable hinting for this font?
Why do you want to prepend en to the font?
Please reformat your xml files with xmllint --format before submission so
they are nicely indented with the same rules as other font packages
- When you've written fontconfig rules you're happy with it's always a good
idea to send them upstream to be included in the font next releases
- Please fine a way to add Barry Schwartz' name in the summary (flattering
font designers is good for our interactions with them)
- Please update http://fedoraproject.org/wiki/BonvenoCF_font to remove the
font from the wishlist (change the Catzgorization). You should not need packaging powers to do that, just a FAS account
All in all, that's not too bad an attempt for a first font package. Fix all this, and I'll sponsor you if that's still needed
hi,
rebuilt the package with your guidelines, as much as i could understand:
SPEC: http://ankursinha.fedorapeople.org/BonvenoCF-fonts/cf-bonveno-fonts.spec
SRPM: http://ankursinha.fedorapeople.org/BonvenoCF-fonts/cf-bonveno-fonts-1.1-1.fc...
I dint know how to tackle point 8 9 10
I dont think i know enough for sposnorship yet.