On Mon, Aug 24, 2015 at 10:41:01PM -0400, Carlos O'Donell wrote:
I've lightly tested this and it seems to be working as expected.
What do you think?
Looks good. I wonder if we should leave benchtests disabled for now.
(a) Add conditional compile targets.
In general it creates conditional compilation targets for:
* testsuite - Enabled by default, allows you to turn off testsuite
* benchtests - Enabled by default.
* werror - Enabled by default. Disabled always for certain targets.
* docs - Enabled by default. Disabling it removes texinfo requirement.
- Bug in check-safety.sh IMO requires makeinfo (texinfo), but
I'll fix this.
* valgrind - Enabled by default. Used to disable valgrind tests.
* bootstrap - Disabled by default. Enabling it automatically turns off
werror, docs, and valgrind.
While %bcond_* simplifies some of the weird logic via the %if %{with foo}
construct, it also leads to more knobs. I don't see any more knobs required
other than those above, so we can always try hard not to slide into lots
of knobs scenario.
(b) Remove c_stubs add-on.
We want full static compilation support and making static binaries smaller
by stubbing stuff out is just going to come back and bite us.
(c) Remove librtkaio support.
Already discussed on fedora devel and in bug 1227855.
Yay!
Siddhesh