[Bug 818256] Review Request: mingw-spice-gtk - client libraries for SPICE desktop servers
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=818256
Hans de Goede <hdegoede(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |hdegoede(a)redhat.com
AssignedTo|nobody(a)fedoraproject.org |hdegoede(a)redhat.com
Flag| |fedora-review?
--- Comment #1 from Hans de Goede <hdegoede(a)redhat.com> 2012-05-10 10:17:30 EDT ---
Full review done:
Good:
--------
- rpmlint checks return:
mingw32-spice-glib.noarch: E: explicit-lib-dependency mingw32-glib2
mingw32-spice-glib.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32
mingw32-spice-gtk.noarch: W: no-documentation
mingw32-spice-gtk-debuginfo.noarch: E: debuginfo-without-sources
mingw32-spice-gtk-static.noarch: W: no-documentation
mingw32-spice-gtk3.noarch: W: no-documentation
mingw64-spice-glib.noarch: E: explicit-lib-dependency mingw64-glib2
mingw64-spice-glib.noarch: W: non-standard-dir-in-usr i686-w64-mingw32
mingw64-spice-gtk.noarch: W: no-documentation
mingw64-spice-gtk-debuginfo.noarch: E: debuginfo-without-sources
mingw64-spice-gtk-static.noarch: W: no-documentation
mingw64-spice-gtk3.noarch: W: no-documentation
10 packages and 0 specfiles checked; 4 errors, 8 warnings.
^^These are all expected for mingw packages, so no problem here ^^
- package meets naming guidelines
- package meets packaging guidelines
- license (LGPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- locales properly handled
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
Needs-work:
-----------------
- you remove all .la files, but non of the other mingw packages I have seen do
that, so it is probably better to not do that. Note, this seems something which
is under discussion:
https://fedoraproject.org/wiki/MinGW/Packaging_issues
But as said I believe for now it is best to just keep the .la files there.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
12 years
[Bug 812575] Review Request: mingw-gstreamer-plugins-bad-free - Cross compiled GStreamer plug-ins "bad"
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812575
Hans de Goede <hdegoede(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-review?
--- Comment #8 from Hans de Goede <hdegoede(a)redhat.com> 2012-05-10 09:27:40 EDT ---
Does not build as is (with a local build on a fully up2date Fedora-17):
There are a number of different problems:
1) The following files are named "bin/libgstfoo-0.10-23.dll" rather then:
"bin/libgstfoo-0.10-0.dll":
bin/libgstbasecamerabinsrc-0.10-0.dll
bin/libgstbasevideo-0.10-0.dll
bin/libgstphotography-0.10-0.dll
bin/libgstsignalprocessor-0.10-0.dll
2) The following files are not listed in %files, but do get installed:
bin/libgstcodecparsers-0.10-23.dll
lib/libgstcodecparsers-0.10.la
lib/libgstcodecparsers-0.10.dll.a
3) The following files are in %files, but do not get build / installed:
lib/gstreamer-%{majorminor}/libgstinvtelecine.dll
lib/gstreamer-%{majorminor}/libgstmpeg4videoparse.dll
4) With the above fixed, rpmbuild will at least run to close to the end, but
there are still more
files which get installed but which are not in any %files:
error: Installed (but unpackaged) file(s) found:
/usr/i686-w64-mingw32/sys-root/mingw/include/gstreamer-0.10/gst/codecparsers/gsth264parser.h
/usr/i686-w64-mingw32/sys-root/mingw/include/gstreamer-0.10/gst/codecparsers/gstmpeg4parser.h
/usr/i686-w64-mingw32/sys-root/mingw/include/gstreamer-0.10/gst/codecparsers/gstmpegvideoparser.h
/usr/i686-w64-mingw32/sys-root/mingw/include/gstreamer-0.10/gst/codecparsers/gstvc1parser.h
/usr/i686-w64-mingw32/sys-root/mingw/include/gstreamer-0.10/gst/video/gstbasevideoutils.h
/usr/i686-w64-mingw32/sys-root/mingw/include/gstreamer-0.10/gst/video/gstsurfacebuffer.h
/usr/i686-w64-mingw32/sys-root/mingw/include/gstreamer-0.10/gst/video/gstsurfaceconverter.h
/usr/i686-w64-mingw32/sys-root/mingw/include/gstreamer-0.10/gst/video/videocontext.h
/usr/i686-w64-mingw32/sys-root/mingw/lib/gstreamer-0.10/libgstaudiovisualizers.dll
/usr/i686-w64-mingw32/sys-root/mingw/lib/gstreamer-0.10/libgstfaceoverlay.dll
/usr/i686-w64-mingw32/sys-root/mingw/lib/gstreamer-0.10/libgstfreeverb.dll
/usr/i686-w64-mingw32/sys-root/mingw/lib/gstreamer-0.10/libgstinter.dll
/usr/i686-w64-mingw32/sys-root/mingw/lib/gstreamer-0.10/libgstremovesilence.dll
/usr/i686-w64-mingw32/sys-root/mingw/lib/gstreamer-0.10/libgstsmooth.dll
/usr/i686-w64-mingw32/sys-root/mingw/lib/gstreamer-0.10/libgstwininet.dll
/usr/i686-w64-mingw32/sys-root/mingw/lib/libgstbasecamerabinsrc-0.10.a
/usr/i686-w64-mingw32/sys-root/mingw/lib/libgstbasevideo-0.10.a
/usr/i686-w64-mingw32/sys-root/mingw/lib/libgstcodecparsers-0.10.a
/usr/i686-w64-mingw32/sys-root/mingw/lib/libgstphotography-0.10.a
/usr/i686-w64-mingw32/sys-root/mingw/lib/libgstsignalprocessor-0.10.a
/usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig/gstreamer-basevideo-0.10.pc
/usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig/gstreamer-codecparsers-0.10.pc
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gstreamer-0.10/gst/codecparsers/gsth264parser.h
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gstreamer-0.10/gst/codecparsers/gstmpeg4parser.h
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gstreamer-0.10/gst/codecparsers/gstmpegvideoparser.h
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gstreamer-0.10/gst/codecparsers/gstvc1parser.h
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gstreamer-0.10/gst/video/gstbasevideoutils.h
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gstreamer-0.10/gst/video/gstsurfacebuffer.h
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gstreamer-0.10/gst/video/gstsurfaceconverter.h
/usr/x86_64-w64-mingw32/sys-root/mingw/include/gstreamer-0.10/gst/video/videocontext.h
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/gstreamer-0.10/libgstaudiovisualizers.dll
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/gstreamer-0.10/libgstfaceoverlay.dll
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/gstreamer-0.10/libgstfreeverb.dll
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/gstreamer-0.10/libgstinter.dll
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/gstreamer-0.10/libgstremovesilence.dll
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/gstreamer-0.10/libgstsmooth.dll
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/gstreamer-0.10/libgstwininet.dll
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libgstbasecamerabinsrc-0.10.a
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libgstbasevideo-0.10.a
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libgstcodecparsers-0.10.a
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libgstcodecparsers-0.10.dll.a
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libgstcodecparsers-0.10.la
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libgstphotography-0.10.a
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libgstsignalprocessor-0.10.a
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/gstreamer-basevideo-0.10.pc
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/gstreamer-codecparsers-0.10.pc
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
12 years
preparing a mingw-llvm package; problems with %mingw_configure environment variables
by Eric Smith
I've finally found time to work on preparing a mingw-llvm-3.0 package,
so that I can cross-compile a program that uses the LLVM libraries.
I've run into a few problems that I could use some help with.
1) The %mingw_configure macro defines a bunch of environment variables
such as AR, CXX, GCC, LD, etc., which interfere with building LLVM,
because the LLVM build system already knows how to deal with
cross-builds, but the env vars screw up some things that have to
compiled and run on the build system. Is there any way to convince
%mingw_configure not to set those variables? Or maybe an alternate
macro that doesn't?
For now, I use a patch to the LLVM configure script that unsets all
those variables at the start, and then it builds fine for mingw32.
2) The LLVM build produces some .exe and .dll files in %{mingw_bindir},
but there aren't any .dll.a or .la files anywhere either in the
BUILDROOT or in the BUILD tree. How are these supposed to be produced?
For my own purposes I only need the static libraries in the -static
subpackage, but obviously I need to fix this so that the DLLs are usable
also.
3) Building for mingw64 fails with all sorts of undefined mangled C++
symbols. I think I'll need help from upstream with that. Is it OK to
submit a package in the mean time that builds for mingw32 only?
For now I've used "%global mingw_build_win64 0". That mostly works,
until rpmbuild tries to generate debuginfo and provides, and apparently
is still looking for an x86_64-w64-mingw32 directory, when all I have is
i686-w64-mingw32. Is there something else I must do to convince it not
to look for 64-bit stuff?
find:
`/home/eric/rpmbuild/BUILDROOT/mingw-llvm-3.0-1.fc16.x86_64/usr/x86_64-w64-mingw32/sys-root/mingw':
No such file or directory
error: failed to write all data to /usr/lib/rpm/mingw-find-debuginfo.sh:
Broken pipe
Finding Provides: /usr/lib/rpm/mingw-find-debuginfo.sh
/home/eric/rpmbuild/BUILD/ mingw32 mingw64
error: Failed to find Provides:
Requires(rpmlib): rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <=
3.0.4-1
RPM build errors:
failed to write all data to /usr/lib/rpm/mingw-find-debuginfo.sh:
Broken pipe
Failed to find Provides:
In case anyone is interested, I put the current
almost-but-not-quite-working spec file and a build log at:
http://fedorapeople.org/~brouhaha/mingw-llvm/
Thanks for any advice and help!
Eric
12 years