On Mon, Mar 31, 2014 at 10:44 AM, Jamie Nguyen j@jamielinux.com wrote:
Alternative suggestion:
%nodejs_fixdep --caret async
%nodejs_fixdep --caret
Sorry for the delay here; everything discussed in this thread has now been implemented (incorporating Jamie's suggestions) and filed as a buildroot override for all active releases.
Also, I added nan to the list of multiply versioned modules so you can go forward with that. (Please rebuild both versions or future packages that depend on the newer versions with look in the new location instead of the old location!)
Thanks! -T.C.
On 05/23/2014 10:39 PM, T.C. Hollingsworth wrote:
On Mon, Mar 31, 2014 at 10:44 AM, Jamie Nguyen j@jamielinux.com wrote:
Alternative suggestion:
%nodejs_fixdep --caret async
%nodejs_fixdep --caret
Sorry for the delay here; everything discussed in this thread has now been implemented (incorporating Jamie's suggestions) and filed as a buildroot override for all active releases.
Also, I added nan to the list of multiply versioned modules so you can go forward with that. (Please rebuild both versions or future packages that depend on the newer versions with look in the new location instead of the old location!)
Thanks! -T.C.
Hi T.C., Thanks for doing this. (The caret stuff as well as the multiply versioned nan.)
One thing I noticed though, after I updated nodejs-nan to 1.0, was that all of the packages that depended on nan, also updated themselves. So after I updated nan, withing 2 weeks, all the dependency errors had gone away because I updated all the packages that depended on it.
That being said, I do see how this is a good thing. nodejs-nan0 is quite different than nodejs-nan1.
Troy
On Tue, May 27, 2014 at 7:17 AM, Troy Dawson tdawson@redhat.com wrote:
Hi T.C., Thanks for doing this. (The caret stuff as well as the multiply versioned nan.)
One thing I noticed though, after I updated nodejs-nan to 1.0, was that all of the packages that depended on nan, also updated themselves. So after I updated nan, withing 2 weeks, all the dependency errors had gone away because I updated all the packages that depended on it.
That being said, I do see how this is a good thing. nodejs-nan0 is quite different than nodejs-nan1.
FWIW Jamie submitted the nodejs-nan0 package and it was already approved for awhile, I just noticed it was sitting around and did the legwork to make it functional. :-)
But I guess this was for nodejs-node-expat; I've been getting spam for it for awhile. (Though some reviews might depend on it too, I really haven't looked that hard.)
If it's really just for node-expat maybe in a little while when I'm not sick I can have a look at porting it to the latest nan so we can drop the compat package.
-T.C.
On 27/05/14 22:37, T.C. Hollingsworth wrote:
FWIW Jamie submitted the nodejs-nan0 package and it was already approved for awhile, I just noticed it was sitting around and did the legwork to make it functional. :-)
Yes I approved nan0 last week, and did remind Jamie that he would need to fix nan at the same time as pushing it.
Tom
On 27/05/14 23:15, Tom Hughes wrote:
On 27/05/14 22:37, T.C. Hollingsworth wrote:
FWIW Jamie submitted the nodejs-nan0 package and it was already approved for awhile, I just noticed it was sitting around and did the legwork to make it functional. :-)
Yes I approved nan0 last week, and did remind Jamie that he would need to fix nan at the same time as pushing it.
Thanks T.C. and Tom.
The review was approved but I hadn't yet built nodejs-nan0. Building nodejs-nan0 while simultaneously amending nodejs-nan was on my TODO list, but looks like T.C. got there first! (I had various other things going on this week.)
Kind regards,
nodejs@lists.fedoraproject.org
-
Jamie Nguyen -
T.C. Hollingsworth -
Tom Hughes -
Troy Dawson