----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/218/#review534 -----------------------------------------------------------
Ship it!
Tested it by killing roled while deploying a role, then restarting it:
[root@vagrant ~]# rolectl list instances [root@vagrant ~]# echo '{"database": "example"}' | rolectl deploy databaseserver --settings-stdin Deployment can take a long time. To monitor the progress, run journalctl -ef -u rolekit Error: Message did not receive a reply (timeout by message bus) [root@vagrant ~]# rolectl list instances databaseserver/1 [root@vagrant ~]# rolectl status databaseserver/1 error [root@vagrant ~]# rolectl decommission --force databaseserver/1 Decommissioning can take a long time. To monitor the progress, run journalctl -ef -u rolekit success [root@vagrant ~]#
- Nils Philippsen
On Sept. 16, 2015, 2:22 vorm., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/218/
(Updated Sept. 16, 2015, 2:22 vorm.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Bugs: 45 http://github.com/libre-server/rolekit/issues#issue/45
Repository: rolekit
Description
A role will never be in a transitional state at startup unless the roled process terminated unexpectedly. In this case, we need to make sure to set the error appropriately, otherwise we won't be able to clean up properly (decommission and reset-error don't work in transitional states).
Fixes: https://github.com/libre-server/rolekit/issues/45
Diffs
src/rolekit/server/dbusrole.py ab65993ead34b2000b1f8150116d9782128ced0f
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/218/diff/
Testing
Thanks,
Stephen Gallagher