Review Request 124: Automatically start roles after deploy()
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/124/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
Repository: rolekit
Description
-------
Many server installers will automatically start their services as
soon as installation is complete (such as FreeIPA). This means that
the real state of the system will disagree with rolekit's view of
it. To be sure that we are aligned, it makes the most sense to just
ensure that all roles are deployed into the RUNNING state.
Diffs
-----
src/rolekit/server/rolebase.py 7f960bf41206c2552996936839a100325382e3be
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/124/diff/
Testing
-------
Deployed a domain controller and verified that after deployment, 'rolectl status domaincontroller/teeceetwo.sgallagh.rht' reported "running" and 'systemctl status role-domaincontroller-teeceetwo.sgallagh.rht.target' reported "active".
Thanks,
Stephen Gallagher
9 years, 3 months
Review Request 122: Limit instance count by plugin _MAX_INSTANCES or global MAX_INSTANCES
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/122/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
If _MAX_INSTANCES is defined in the role, then it will be used as the maximum
count of instances for this role. If is is not defined, the global
MAX_INSTANCES definition will be used.
To set a different maximum instance count, add _MAX_INSTANCES=X to the Role
definition in role.py next to _DEFAULTS and _READONLY_SETTINGS.
Diffs
-----
src/rolekit/server/dbusrole.py 5f978215a94e304ae76b410a59ec7f598219cedc
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/122/diff/
Testing
-------
Thanks,
Thomas Woerner
9 years, 5 months
Review Request 118: Domain Controller: Relax primary_ip restriction
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/118/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
FreeIPA 4.1 will fix the bug making this option mandatory. We will
be shipping rolekit together with that release, so we should relax
this check.
This should not be pushed upstream until FreeIPA 4.1 is submitted for stable in Fedora.
Diffs
-----
config/roles/domaincontroller/role.py b36cb15b2890555f077cdb14d2d2240d8a882d9b
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/118/diff/
Testing
-------
Installed the FreeIPA 4.1 testing packages and ran a deploy without **primary_ip** specified in the settings.json file.
Thanks,
Stephen Gallagher
9 years, 5 months