August 2014 - rolekit-commits - Fedora Mailing-Lists

Review Request 54: Implement starting and stopping services, and use it in databaseserver.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/54/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- Implement starting and stopping services, and use it in databaseserver. Includes some work-in-progress edits to databaseserver, IMHO harmless enough but will split them if asked. Now rereading this, should the StartUnit/StopUnit D-Bus calls be non-blocking as well? At this late hour I’m inclined to say that they are explicitly designed to be returning quickly, so it isn’t really necessary. Diffs ----- TODO 053560af7e811ae9d26b7eafff92ac2786af5408 config/roles/databaseserver/role.py b632321de63c331b3b3d0445d134fe1626e9944c src/rolekit/dbus_utils.py fb21cec2681f60ec2ad30372c4caf285e8ba13a7 src/rolekit/server/rolebase.py d53c745352183944e307cca5259a58f058f81e27 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/54/diff/ Testing ------- starting/stopping postgres through d-feet. Thanks, Miloslav Trmac

9 years, 8 months

1
10
0 / 0

Review Request 65: Add an async.async_subprocess_future helper.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/65/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- This uses the GLib mainloop infrastructure for polling. Also establishes a _future naming suffix for functions that return futures. Diffs ----- src/rolekit/async.py 1e2b82eab5a4e6862594672f738c1935a83c2be5 tests/async_test.py 47a54ed408657e67e797d50d7c73d9a7982bcfc3 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/65/diff/ Testing ------- Thanks, Miloslav Trmac

9 years, 8 months

1
7
0 / 0

Review Request 70: Change async naming conventions.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/70/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Establish a _future suffix convention for functions returning futures. Drop async_ from names of all functions within the async module as unnecessarily redundant. To avoid confusion, document that this module should always be used as “async.function_name” (i.e. each time referring to the async nature of the functionality). Hence, also replace __all__ because it is a maintenance burden, and only useful for “from async import *”, which we actively want to break rather than support. Diffs ----- src/rolekit/async.py 0a820c383d89fd6e8a6df22968cf7bae06228b14 src/rolekit/server/dbusrole.py fdf8632b9febbe0a3a358428d065d0d63dda8777 src/rolekit/server/decorators.py 6ea1ba1e5eaad99c58b8618c4386fd2ee967619c src/rolekit/server/rolebase.py a54a3b61b107775140a944a94bedd2dd0fa4ec81 tests/async_test.py 47a54ed408657e67e797d50d7c73d9a7982bcfc3 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/70/diff/ Testing ------- Thanks, Miloslav Trmac

9 years, 8 months

1
2
0 / 0

Review Request 56: Convert exceptions in D-Bus methods as if by @dbus_handle_exceptions.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/56/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner. Repository: rolekit Description ------- This really does call for a decorator that allows us to just say @dbus_service_method_async def deploy_async(..., no_handlers_here): yield None but that’s for later. Diffs ----- src/rolekit/async.py 1e2b82eab5a4e6862594672f738c1935a83c2be5 src/rolekit/server/dbusrole.py 8a13ccccbb0c9d2940f485697d9d2ef644183b15 src/rolekit/server/decorators.py a0c8cf4a86a7391843c33b98e344532b564868e5 src/rolekit/server/rolebase.py d53c745352183944e307cca5259a58f058f81e27 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/56/diff/ Testing ------- Thanks, Miloslav Trmac

9 years, 8 months

1
3
0 / 0

Review Request 62: Add asynchronous helper for calling a subprocess

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/62/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- This will spawn a thread to monitor the subprocess, capture both stdout and stderr and throw an exception if the process terminates with a non-zero error code. Diffs ----- src/rolekit/async.py 1e2b82eab5a4e6862594672f738c1935a83c2be5 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/62/diff/ Testing ------- Manual testing was done by having it call a script that slept for 30s and verifying that other requests could be successfully made to rolekit while it was waiting. This code probably needs a unit test, but I haven't written it yet. Thanks, Stephen Gallagher

9 years, 8 months

1
10
0 / 0

Review Request 67: Missing resetError method for instances

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/67/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Adds resetError to RoleBase and reset-error to rolectl Diffs ----- src/rolectl d99deab3d054579488551dd6cd61615f919bd018 src/rolekit/client.py f56405183f14bfab29dea6d77ae958ece2775761 src/rolekit/server/rolebase.py 8591f8aade76d3463647c59b43cc83877698182d Diff: http://reviewboard-fedoraserver.rhcloud.com/r/67/diff/ Testing ------- Thanks, Thomas Woerner

9 years, 8 months

1
3
0 / 0

Review Request 68: Better message for INVALID_STATE error

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/68/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Better message for INVALID_STATE error Diffs ----- src/rolekit/server/rolebase.py 8591f8aade76d3463647c59b43cc83877698182d Diff: http://reviewboard-fedoraserver.rhcloud.com/r/68/diff/ Testing ------- Thanks, Thomas Woerner

9 years, 8 months

1
3
0 / 0

Review Request 64: Use "@VERSION@" for ROLEKIT_VERSION

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/64/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- With this change the proper version of rolekit is used in the D-Bus interface. Diffs ----- src/rolekit/config/__init__.py.in 72d403e2f51a5b1b5fe44d178a72b52468423bca Diff: http://reviewboard-fedoraserver.rhcloud.com/r/64/diff/ Testing ------- Thanks, Thomas Woerner

9 years, 8 months

1
3
0 / 0

Review Request 61: Fix minor typo in async_test

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/61/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Fix minor typo in async_test Diffs ----- tests/async_test.py 98eaa931a5af3ff11cf64d35d8f8855c67937fbd Diff: http://reviewboard-fedoraserver.rhcloud.com/r/61/diff/ Testing ------- Thanks, Stephen Gallagher

9 years, 8 months

1
1
0 / 0

Review Request 60: Make auto-termination working within RoleBase and DBusRole also

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/60/ ----------------------------------------------------------- Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Make auto-termination working within RoleBase and DBusRole also Diffs ----- src/rolekit/server/dbusrole.py 5a70df48b8dbce4e49b6ec02e731ede9ab31b7f6 src/rolekit/server/rolebase.py d53c745352183944e307cca5259a58f058f81e27 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/60/diff/ Testing ------- Thanks, Thomas Woerner

9 years, 9 months

1
4
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

rolekit-commits August 2014