----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/179/#review460 ----------------------------------------------------------- rolectl tries to contact roled early (see rk.connected check). This is the first place where rolectl stops. The second one is the first line after 'elif command == "deploy":' In the "--next-boot" case this needs to be done later. The question is if it would not be better to have a separte command to prepare next-boot deployments. - Thomas Woerner On Aug. 5, 2015, 12:42 a.m., Stephen Gallagher wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/179/#review461 ----------------------------------------------------------- src/rolectl (line 144) <http://reviewboard-fedoraserver.rhcloud.com/r/179/#comment264> Please ass this option also in the man page. src/rolectl (line 301) <http://reviewboard-fedoraserver.rhcloud.com/r/179/#comment263> This is not consistent to the normal role name behavior. The next free id from ETC_ROLEKIT_PENDINGROLES/<type>/%d.json and ETC_ROLEKIT_ROLES/<type>/%d.json should be used here. - Thomas Woerner On Aug. 6, 2015, 1:50 p.m., Stephen Gallagher wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/179/#review474 ----------------------------------------------------------- src/rolekit/server/io/rolesettings.py (line 38) <http://reviewboard-fedoraserver.rhcloud.com/r/179/#comment267> Please add a check if ETC_ROLEKIT_PENDINGROLES exists, otherwise there will be a traceback in write later on. - Thomas Woerner On Aug. 18, 2015, 7:29 p.m., Stephen Gallagher wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/179/ ----------------------------------------------------------- (Updated Aug. 26, 2015, 6:23 p.m.) Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner. Changes ------- Added bash-completion script as requested. Added a check for root privileges before attempting to create pending roles. Made the missing directory creation a debug message rather than an info message to avoid spamming the user. Bugs: 1 http://github.com/libre-server/rolekit/issues#issue/1 Repository: rolekit Description ------- We want to be able to support configuring role deployments during automated system setup (such as Anaconda kickstart for Fedora and Red Hat Enterprise Linux systems). With this patch, we add a --next-boot argument to 'rolectl deploy'. This will cause a one- time systemd service unit to be created and configured to run at the first boot. This service unit will execute the real 'rolectl deploy' after the network is online and will process the role deployment, then delete the temporary files. These files will not be deleted in the event of an error. Fixes https://github.com/libre-server/rolekit/issues/1 Diffs (updated) ----- config/Makefile.am 480f74f450bb2c6397848e20e3973be806123302 doc/xml/rolectl.xml 6048870abcf21942d37a87275029ad3fed311258 rolekit.spec 0acce035a3745572226e93443515eb0d20b0c77e shell-completion/bash/rolectl b32b71e7713d7a40236db07faae8ecca481753dd src/Makefile.am bbcdf37b417416fa0a5eeeb800a81417f3b81380 src/rolectl ade941d99ce04d62b17714ee4c624d2b73249281 src/rolekit/config/__init__.py.in d9295f37061576fe697402206e18342e0f0a22be src/rolekit/rolectl/__init__.py PRE-CREATION src/rolekit/server/io/rolesettings.py 18f4871faf87ba23d21a3f9bc2c13b14463a8ccf src/rolekit/server/rolebase.py 121a9b706ee2dda37eff116b8fc7a50143b2e1a6 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/179/diff/ Testing ------- Deployed the memcache role with --next-boot. Tested it by doing 'systemctl start pendingrole-memcache-name.service' It has not been tested with an actual kickstart yet; I am waiting for Alpha RC1 to arrive and will test it with that. Thanks, Stephen Gallagher

The service of a delayed deploy is removed at the end of a successful deploy process. See line 993-1015 of rolebase.py. If it's not *actually* removed, then it's possible there's an SELinux permission bug. But the `ConditionPathExists` bit of the unit file prevents it from trying to continue deploying. Yes, we should open a bug to allow cancelling a pending deployment (before it starts, of course). That last one should be an issue with this patch. I'll fix it. - Stephen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/179/#review497 ----------------------------------------------------------- On Aug. 26, 2015, 6:23 p.m., Stephen Gallagher wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/179/#review499 ----------------------------------------------------------- src/rolekit/server/io/rolesettings.py (line 63) <http://reviewboard-fedoraserver.rhcloud.com/r/179/#comment293> This is resulting in a ValueError for already deployed roles (instances) while roled starts. The ValueError should only happen if there is another instance or pendingrole with the same name. It should not complain on a conflict the instance iteself. - Thomas Woerner On Aug. 31, 2015, 3:37 p.m., Stephen Gallagher wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/179/ ----------------------------------------------------------- (Updated Sept. 1, 2015, 12:15 p.m.) Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner. Changes ------- Don't throw an error when trying to load existing roles. Also, remove a legacy check for name generation. Bugs: 1 http://github.com/libre-server/rolekit/issues#issue/1 Repository: rolekit Description ------- We want to be able to support configuring role deployments during automated system setup (such as Anaconda kickstart for Fedora and Red Hat Enterprise Linux systems). With this patch, we add a --next-boot argument to 'rolectl deploy'. This will cause a one- time systemd service unit to be created and configured to run at the first boot. This service unit will execute the real 'rolectl deploy' after the network is online and will process the role deployment, then delete the temporary files. These files will not be deleted in the event of an error. Fixes https://github.com/libre-server/rolekit/issues/1 Diffs (updated) ----- config/Makefile.am 480f74f450bb2c6397848e20e3973be806123302 doc/xml/rolectl.xml c1e18b17e458a95d80f6a91a4059ac5a8a12c63a rolekit.spec 6bb09a3c58fb57fd9265c2de5b29f13569fde120 shell-completion/bash/rolectl cc9b329059e5b8d6f719537e9cab97a599281ab6 src/Makefile.am bbcdf37b417416fa0a5eeeb800a81417f3b81380 src/rolectl 466d93a000fd7ccfe2786f536e69a23e65b916e3 src/rolekit/config/__init__.py.in d9295f37061576fe697402206e18342e0f0a22be src/rolekit/rolectl/__init__.py PRE-CREATION src/rolekit/server/io/rolesettings.py e04896c826b962f71c4552a95656c93c7f2049f9 src/rolekit/server/rolebase.py 7547decb545d30408b80d05784ecd7084462365e Diff: http://reviewboard-fedoraserver.rhcloud.com/r/179/diff/ Testing ------- Deployed the memcache role with --next-boot. Tested it by doing 'systemctl start pendingrole-memcache-name.service' It has not been tested with an actual kickstart yet; I am waiting for Alpha RC1 to arrive and will test it with that. Thanks, Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/179/ ----------------------------------------------------------- (Updated Sept. 1, 2015, 2:23 p.m.) Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner. Changes ------- Replace \-\-next-boot with \-\-deferred in the description. Bugs: 1 http://github.com/libre-server/rolekit/issues#issue/1 Repository: rolekit Description (updated) ------- We want to be able to support configuring role deployments during automated system setup (such as Anaconda kickstart for Fedora and Red Hat Enterprise Linux systems). With this patch, we add a --deferred argument to 'rolectl deploy'. This will cause a one- time systemd service unit to be created and configured to run at the first boot. This service unit will execute the real 'rolectl deploy' after the network is online and will process the role deployment, then delete the temporary files. These files will not be deleted in the event of an error. Fixes https://github.com/libre-server/rolekit/issues/1 Diffs ----- config/Makefile.am 480f74f450bb2c6397848e20e3973be806123302 doc/xml/rolectl.xml c1e18b17e458a95d80f6a91a4059ac5a8a12c63a rolekit.spec 6bb09a3c58fb57fd9265c2de5b29f13569fde120 shell-completion/bash/rolectl cc9b329059e5b8d6f719537e9cab97a599281ab6 src/Makefile.am bbcdf37b417416fa0a5eeeb800a81417f3b81380 src/rolectl 466d93a000fd7ccfe2786f536e69a23e65b916e3 src/rolekit/config/__init__.py.in d9295f37061576fe697402206e18342e0f0a22be src/rolekit/rolectl/__init__.py PRE-CREATION src/rolekit/server/io/rolesettings.py e04896c826b962f71c4552a95656c93c7f2049f9 src/rolekit/server/rolebase.py 7547decb545d30408b80d05784ecd7084462365e Diff: http://reviewboard-fedoraserver.rhcloud.com/r/179/diff/ Testing (updated) ------- Deployed the memcache role with --next-boot. Tested it by doing 'systemctl start pendingrole-memcache-name.service' Thanks, Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/179/#review503 ----------------------------------------------------------- Ship it! Ship It! - Thomas Woerner On Sept. 1, 2015, 2:47 p.m., Stephen Gallagher wrote: