----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/196/ ----------------------------------------------------------- (Updated Aug. 26, 2015, 1:21 p.m.) Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Only the changed signal is supported right now. As soon as a settings is modified, the connected handler will be called for this setting. Diffs ----- src/rolekit/server/io/rolesettings.py 18f4871faf87ba23d21a3f9bc2c13b14463a8ccf Diff: http://reviewboard-fedoraserver.rhcloud.com/r/196/diff/ Testing ------- Thanks, Thomas Woerner

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/196/#review481 ----------------------------------------------------------- src/rolekit/server/io/rolesettings.py (line 43) <http://reviewboard-fedoraserver.rhcloud.com/r/196/#comment278> Typo: "conenct" -> "connect" src/rolekit/server/io/rolesettings.py (lines 52 - 55) <http://reviewboard-fedoraserver.rhcloud.com/r/196/#comment279> Wouldn't it be more "pythonic" to do: ``` try: self._callbacks[signal] = (handler, args) except KeyError: raise ValueError("Unknown signal name '%s'" % name) ``` src/rolekit/server/io/rolesettings.py (lines 68 - 69) <http://reviewboard-fedoraserver.rhcloud.com/r/196/#comment281> Similarly, isn't it more pythonic for this to be: ``` try: cb = self._callbacks["changed"] except KeyError: # Log the lack of a changed callback return cb_args = [ key, value ] ... ``` src/rolekit/server/io/rolesettings.py (lines 72 - 74) <http://reviewboard-fedoraserver.rhcloud.com/r/196/#comment282> ``` try: cb_args.extend(cb[1]) except TypeError: # Got None here pass ``` - Stephen Gallagher On Aug. 26, 2015, 1:21 p.m., Thomas Woerner wrote:

Ah, you are right of course. I was a little mixed up there. - Stephen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/196/#review481 ----------------------------------------------------------- On Aug. 26, 2015, 1:21 p.m., Thomas Woerner wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/196/#review483 ----------------------------------------------------------- src/rolekit/server/io/rolesettings.py (lines 52 - 55) <http://reviewboard-fedoraserver.rhcloud.com/r/196/#comment283> 'name' should be 'signal' here. - Stephen Gallagher On Aug. 26, 2015, 1:21 p.m., Thomas Woerner wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/196/ ----------------------------------------------------------- (Updated Aug. 26, 2015, 4:10 p.m.) Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Only the changed signal is supported right now. As soon as a settings is modified, the connected handler will be called for this setting. Diffs (updated) ----- src/rolekit/server/io/rolesettings.py f9fc1f7904a403b28fc6ead4ada89f489e408a41 src/rolekit/server/rolebase.py 121a9b706ee2dda37eff116b8fc7a50143b2e1a6 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/196/diff/ Testing ------- Thanks, Thomas Woerner

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/196/ ----------------------------------------------------------- (Updated Aug. 26, 2015, 7:29 p.m.) Status ------ This change has been marked as submitted. Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- Only the changed signal is supported right now. As soon as a settings is modified, the connected handler will be called for this setting. Diffs ----- src/rolekit/server/io/rolesettings.py f9fc1f7904a403b28fc6ead4ada89f489e408a41 src/rolekit/server/rolebase.py 121a9b706ee2dda37eff116b8fc7a50143b2e1a6 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/196/diff/ Testing ------- Thanks, Thomas Woerner