----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/123/#review358 ----------------------------------------------------------- doc/xml/rolekit.roles.xml <http://reviewboard-fedoraserver.rhcloud.com/r/123/#comment188> s/Steps check/Steps to check/ doc/xml/rolekit.roles.xml <http://reviewboard-fedoraserver.rhcloud.com/r/123/#comment189> Put "prop" in quotes to indicate that it's an argument. doc/xml/rolekit.roles.xml <http://reviewboard-fedoraserver.rhcloud.com/r/123/#comment190> Let's make this more clear (because I was confused by this myself, actually). We return False if-and-only-if the do_check_property method was *incapable* of checking this property. - Stephen Gallagher On Nov. 13, 2014, 4:50 p.m., Thomas Woerner wrote:

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/123/#review359 ----------------------------------------------------------- Ship it! Ship It! - Stephen Gallagher On Nov. 17, 2014, 6:32 p.m., Thomas Woerner wrote: