On Mon, Aug 20, 2018 at 4:30 AM Kevin Fenzi <kevin(a)scrye.com> wrote:
On 08/18/2018 05:04 PM, Amit Saha wrote:
> On Fri, 17 Aug 2018 at 9:21 am, Amit Saha <amitsaha.in(a)gmail.com> wrote:
>
>> I should have created the PR for f29 branch as well:
>>
https://pagure.io/fedora-kickstarts/pull-request/413
>>
>> Thanks in advance.
>>
>
> Can someonep please merge this?
Sure.
Do you want to also make the change in master/rawhide?
Thanks Kevin. Yes, I actually did that in a previous PR.
Finally, can we work out a better workflow here than filing PR's and
then pinging people to merge them? Either we need to add more people who
can review or something, but I'm not a fan of processes that require
people to always ask for things. ;)
Yes, I think that will be great. Before we moved to the PR based workflow,
I would just push directly, since I had push rights. However, I can see why
we may want a PR based workflow. However, it does block me from merging
quick/small changes which will not have any impact beyond the specific
spin.
So, any changes to that process will be great.
kevin
--
>
>
>>
>> On Thu, Aug 16, 2018 at 5:20 PM Amit Saha <amitsaha.in(a)gmail.com>
wrote:
>>
>>> Hi all,
>>>
>>> Can someone with merge rights please merge:
>>>
https://pagure.io/fedora-kickstarts/pull-request/412 ?
>>>
>>> Thanks,
>>> Amit.
>>>
>>>
>
>
>
> _______________________________________________
> spins mailing list -- spins(a)lists.fedoraproject.org
> To unsubscribe send an email to spins-leave(a)lists.fedoraproject.org
> Fedora Code of Conduct:
https://getfedora.org/code-of-conduct.html
> List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
https://lists.fedoraproject.org/archives/list/spins@lists.fedoraproject.o...
>
_______________________________________________
spins mailing list -- spins(a)lists.fedoraproject.org
To unsubscribe send an email to spins-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://getfedora.org/code-of-conduct.html
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/spins@lists.fedoraproject.o...