5:21 a.m.
Hi,
can someone help me to find how to correct this bug
(https://bugs.mageia.org/show_bug.cgi?id=14981)?
"For the default printer, a green check mark is placed on the printer
icon. In Cauldron's version, it shows two check marks (top left and
right) and some visual artifacts (bottom half of the icon) on the
icon."
any clue on what I have to look for ?
Thanks
6:14 a.m.
On Tue, 2015-02-17 at 12:21 +0100, philippe makowski wrote:
"For the default printer, a green check mark is placed on the
printer
icon. In Cauldron's version, it shows two check marks (top left and
right) and some visual artifacts (bottom half of the icon) on the
icon."
any clue on what I have to look for ?
Take a look for 'composite' in system-config-printer.py. It uses this
method to compose the icon with both the 'default' emblem and any other
state emblem as needed.
Tim.
*/
5:57 a.m.
2015-02-18 13:14 GMT+01:00 Tim Waugh <twaugh(a)redhat.com>:
Take a look for 'composite' in system-config-printer.py. It uses this
method to compose the icon with both the 'default' emblem and any other
state emblem as needed.
Thanks.
Strange, and I don't really understand why, but it seems that this
patch fix the problem
Index: system-config-printer.py
===================================================================
--- system-config-printer.py
+++ system-config-printer.py 2015-02-21 12:45:22.619980289 +0100
@@ -1000,7 +1000,7 @@
copy.fill (0)
pixbuf.composite (copy, 0, 0,
copy.get_width(), copy.get_height(),
- 0, 0, 1.0, 1.0,
+ 0, 0, 1.01, 1.01,
GdkPixbuf.InterpType.BILINEAR, 127)
pixbuf = copy
@@ -1013,7 +1013,7 @@
copy.get_width (),
copy.get_height (),
0, 0,
- 1.0, 1.0,
+ 1.01, 1.01,
GdkPixbuf.InterpType.NEAREST, 255)
pixbuf = copy
except GLib.GError:
@@ -1029,7 +1029,7 @@
copy.get_height (),
copy.get_width () / 2,
copy.get_height () / 2,
- 1.0, 1.0,
+ 1.01, 1.01,
GdkPixbuf.InterpType.NEAREST, 255)
pixbuf = copy
except GLib.GError:
6:21 a.m.
On Sat, 2015-02-21 at 12:57 +0100, philippe makowski wrote:
Strange, and I don't really understand why, but it seems that
this
patch fix the problem
Index: system-config-printer.py
===================================================================
--- system-config-printer.py
+++ system-config-printer.py 2015-02-21 12:45:22.619980289 +0100
@@ -1000,7 +1000,7 @@
copy.fill (0)
pixbuf.composite (copy, 0, 0,
copy.get_width(), copy.get_height(),
- 0, 0, 1.0, 1.0,
+ 0, 0, 1.01, 1.01,
That's odd. Could you set a breakpoint on gdk_pixbuf_composite() and
find out why that makes a difference?
Tim.
*/
12:57 p.m.
On Tue, 2015-02-17 at 12:21 +0100, philippe makowski wrote:
"For the default printer, a green check mark is placed on the
printer icon. In Cauldron's version, it shows two check marks (top
left and right) and some visual artifacts (bottom half of the icon)
on the icon."
This is fixed now:
https://git.fedorahosted.org/cgit/system-config-printer.git/commit/?h=1.4...
Tim.
*/
1:18 p.m.
Hi,
2015-03-17 18:57 GMT+01:00 Tim Waugh <twaugh(a)redhat.com>:
On Tue, 2015-02-17 at 12:21 +0100, philippe makowski wrote:
> "For the default printer, a green check mark is placed on the
> printer icon. In Cauldron's version, it shows two check marks (top
> left and right) and some visual artifacts (bottom half of the icon)
> on the icon."
This is fixed now:
https://git.fedorahosted.org/cgit/system-config-printer.git/commit/?h=1.4...
Thanks
3333
days inactive
3361
days old
system-config-printer-devel@lists.fedorahosted.org
5 comments
2 participants
participants (2)
-
philippe makowski -
Tim Waugh