Adam Litke has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/25988/6/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 716:
Line 717: @contextmanager
Line 718: def getVolumeMetadataSlot(self, vol_name, slotSize):
Line 719: # TODO: _lvTagMetaSlotLock should be relevant only when we use
Line 720: # getFreeMetadataSlot to avoid a race between getting the occupied
Seems that _lvTagMetaSlotLock should be used only when using
getFreeMetadat
Done
Line 721: # metadata slots and tagging the new LV (commit to the new slot).
Line 722: with self._lvTagMetaSlotLock:
Line 723: if self.getVersion() in VERS_METADATA_LV:
Line 724: yield self.getVolumeMetadataOffsetFromPvMapping(vol_name)
--
To view, visit
https://gerrit.ovirt.org/25988
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes