1:24 p.m.
Federico Simoncelli has uploaded a new change for review.
Change subject: block: use the contextmanager for mapMetaOffset
......................................................................
block: use the contextmanager for mapMetaOffset
Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M vdsm/storage/blockSD.py
M vdsm/storage/blockVolume.py
M vdsm/storage/imageRepository/formatConverter.py
3 files changed, 13 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/25988/1
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index cac59fa..02c7dfd 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -29,6 +29,7 @@
import time
import functools
from collections import namedtuple
+from contextlib import contextmanager
from operator import itemgetter
from vdsm.config import config
@@ -732,11 +733,15 @@
newsize = self.metaSize(self.sdUUID)
lvm.extendLV(self.sdUUID, sd.METADATA, newsize)
+ _mdSlotLock = threading.Lock()
+
+ @contextmanager
def mapMetaOffset(self, vol_name, slotSize):
- if self.getVersion() in VERS_METADATA_LV:
- return self.getVolumeMetadataOffsetFromPvMapping(vol_name)
- else:
- return self.getFreeMetadataSlot(slotSize)
+ with self._mdSlotLock:
+ if self.getVersion() in VERS_METADATA_LV:
+ yield self.getVolumeMetadataOffsetFromPvMapping(vol_name)
+ else:
+ yield self.getFreeMetadataSlot(slotSize)
def _getOccupiedMetadataSlots(self):
stripPrefix = lambda s, pfx: s[len(pfx):]
diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py
index 36bfa1f..9a7fa81 100644
--- a/vdsm/storage/blockVolume.py
+++ b/vdsm/storage/blockVolume.py
@@ -73,7 +73,6 @@
class BlockVolume(volume.Volume):
""" Actually represents a single volume (i.e. part of virtual disk).
"""
- _tagCreateLock = threading.Lock()
def __init__(self, repoPath, sdUUID, imgUUID, volUUID):
self.metaoff = None
@@ -169,8 +168,7 @@
imgUUID, volUUID, srcImgUUID, srcVolUUID)
volParent.clone(imgPath, volUUID, volFormat, preallocate)
- with cls._tagCreateLock:
- mdSlot = dom.mapMetaOffset(volUUID, VOLUME_MDNUMBLKS)
+ with dom.mapMetaOffset(volUUID, VOLUME_MDNUMBLKS) as mdSlot:
mdTags = ["%s%s" % (TAG_PREFIX_MD, mdSlot),
"%s%s" % (TAG_PREFIX_PARENT, srcVolUUID),
"%s%s" % (TAG_PREFIX_IMAGE, imgUUID)]
diff --git a/vdsm/storage/imageRepository/formatConverter.py
b/vdsm/storage/imageRepository/formatConverter.py
index c701163..11a0039 100644
--- a/vdsm/storage/imageRepository/formatConverter.py
+++ b/vdsm/storage/imageRepository/formatConverter.py
@@ -180,9 +180,9 @@
metaOffset, vol.volUUID)
metaContent = vol.getMetadata()
- with vol._tagCreateLock:
- newMetaOffset = domain.mapMetaOffset(
- vol.volUUID, blockVolume.VOLUME_MDNUMBLKS)
+ with domain.mapMetaOffset(
+ vol.volUUID, blockVolume.VOLUME_MDNUMBLKS) \
+ as newMetaOffset:
if newMetaOffset > metaMaxSlot:
raise se.NoSpaceLeftOnDomain(domain.sdUUID)
--
To view, visit http://gerrit.ovirt.org/25988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
1:24 p.m.
Federico Simoncelli has posted comments on this change.
Change subject: block: use the contextmanager for mapMetaOffset
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25988/1//COMMIT_MSG
Commit Message:
Line 4: Commit: Federico Simoncelli <fsimonce(a)redhat.com>
Line 5: CommitDate: 2014-03-21 14:24:12 -0400
Line 6:
Line 7: block: use the contextmanager for mapMetaOffset
Line 8:
TODO: commit message
Line 9: Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
--
To view, visit http://gerrit.ovirt.org/25988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes
1:26 p.m.
Federico Simoncelli has posted comments on this change.
Change subject: block: use the contextmanager for mapMetaOffset
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25988/1/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 735:
Line 736: _mdSlotLock = threading.Lock()
Line 737:
Line 738: @contextmanager
Line 739: def mapMetaOffset(self, vol_name, slotSize):
acquireNewMetaOffset?
Line 740: with self._mdSlotLock:
Line 741: if self.getVersion() in VERS_METADATA_LV:
Line 742: yield self.getVolumeMetadataOffsetFromPvMapping(vol_name)
Line 743: else:
--
To view, visit http://gerrit.ovirt.org/25988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes
1:26 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: use the contextmanager for mapMetaOffset
......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6789/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7579/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7689/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/25988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:55 a.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6960/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7862/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7751/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/25988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:37 a.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7067/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7969/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7858/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/25988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
11:25 a.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
Federico Simoncelli has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Patch Set 3: Verified+1
Verified with:
* http://gerrit.ovirt.org/25988
* http://gerrit.ovirt.org/26265
* http://gerrit.ovirt.org/26266
Tests:
* test metadata slot reallocation (formatConverter)
* test new volume creations
--
To view, visit http://gerrit.ovirt.org/25988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:22 a.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
Itamar Heim has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Patch Set 3:
ping
--
To view, visit http://gerrit.ovirt.org/25988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:33 a.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
Itamar Heim has abandoned this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Abandoned
no activity. restore if still relevant
--
To view, visit http://gerrit.ovirt.org/25988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
6:38 a.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
Federico Simoncelli has restored this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Restored
--
To view, visit http://gerrit.ovirt.org/25988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: restore
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
3:34 p.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
Nir Soffer has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/25988/3/tests/volumeTests.py
File tests/volumeTests.py:
Line 97: self.assertEqual(mdSlot, self.EXPECTED_METADATA_SLOT)
Line 98:
Line 99: def testMetaSlotLock(self):
Line 100: with self.blksd.getVolumeMetadataSlot(None, 1):
Line 101: lktaken = self.blksd._lvTagMetaSlotLock.acquire(False)
This will break if we rename the private lock or move it to other class. We want to test
that only one thread can enter this context, not that is locks some specific lock.
http://gerrit.ovirt.org/#/c/25988/3/vdsm/storage/imageRepository/formatCo...
File vdsm/storage/imageRepository/formatConverter.py:
Line 181: metaContent = vol.getMetadata()
Line 182:
Line 183: with domain.getVolumeMetadataSlot(
Line 184: vol.volUUID, blockVolume.VOLUME_MDNUMBLKS) \
Line 185: as newMetaSlot:
I think this would be little more clear as:
newMetaSlot = domain.getVolumeMetadataSlot(
vol.volUUID, blockVolume.VOLUME_MDNUMBLKS)
with newMetaSlot:
...
Line 186: if newMetaSlot > metaMaxSlot:
Line 187: raise se.NoSpaceLeftOnDomain(domain.sdUUID)
Line 188:
Line 189: log.debug("Copying metadata for volume %s to the new slot
%s",
--
To view, visit http://gerrit.ovirt.org/25988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
6:59 p.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
Nir Soffer has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/25988/3/tests/volumeTests.py
File tests/volumeTests.py:
Line 97: self.assertEqual(mdSlot, self.EXPECTED_METADATA_SLOT)
Line 98:
Line 99: def testMetaSlotLock(self):
Line 100: with self.blksd.getVolumeMetadataSlot(None, 1):
Line 101: lktaken = self.blksd._lvTagMetaSlotLock.acquire(False)
This will break if we rename the private lock or move it to other
class. We
See http://gerrit.ovirt.org/30938 for a way to test this without poking
into blockVolume internals.
--
To view, visit http://gerrit.ovirt.org/25988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
2:58 p.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
automation(a)ovirt.org has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit http://gerrit.ovirt.org/25988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3 p.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16017/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15217/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16187/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/993/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/25988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:51 p.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
automation(a)ovirt.org has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4 p.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16078/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15278/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16248/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1054/ : FAILURE
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:55 p.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
automation(a)ovirt.org has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:58 p.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16465/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16636/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_el_gerrit/15665/ : FAILURE
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:22 p.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
Dan Kenigsberg has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/25988/6//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014-03-21 14:22:41 -0400
Line 4: Commit: Adam Litke <alitke(a)redhat.com>
Line 5: CommitDate: 2015-03-09 16:55:21 -0400
Line 6:
Line 7: block: use the contextmanager for getVolumeMetadataSlot
English: convert getVolumeMetadataSlot into a contexmanager
"the contextmanager" led me to think that a contextmanager has already been
defined in the past.
Line 8:
Line 9: Using the contextmanager on getVolumeMetadataSlot allows us to hide the
Line 10: metadata slot lock inside the StorageDomain object instead of having to
Line 11: use it from other modules (e.g. formatConverter).
https://gerrit.ovirt.org/#/c/25988/6/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 716:
Line 717: @contextmanager
Line 718: def getVolumeMetadataSlot(self, vol_name, slotSize):
Line 719: # TODO: _lvTagMetaSlotLock should be relevant only when we use
Line 720: # getFreeMetadataSlot to avoid a race between getting the occupied
sorry, I do not understand this TODO. The suggested code takes the lock for all usages of
getVolumeMetadataSlot, just as the current code does.
When is this locking redundant?
Line 721: # metadata slots and tagging the new LV (commit to the new slot).
Line 722: with self._lvTagMetaSlotLock:
Line 723: if self.getVersion() in VERS_METADATA_LV:
Line 724: yield self.getVolumeMetadataOffsetFromPvMapping(vol_name)
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
8:58 a.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
Adam Litke has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/25988/6//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014-03-21 14:22:41 -0400
Line 4: Commit: Adam Litke <alitke(a)redhat.com>
Line 5: CommitDate: 2015-03-09 16:55:21 -0400
Line 6:
Line 7: block: use the contextmanager for getVolumeMetadataSlot
English: convert getVolumeMetadataSlot into a contexmanager
Done
Line 8:
Line 9: Using the contextmanager on getVolumeMetadataSlot allows us to hide the
Line 10: metadata slot lock inside the StorageDomain object instead of having to
Line 11: use it from other modules (e.g. formatConverter).
https://gerrit.ovirt.org/#/c/25988/6/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 716:
Line 717: @contextmanager
Line 718: def getVolumeMetadataSlot(self, vol_name, slotSize):
Line 719: # TODO: _lvTagMetaSlotLock should be relevant only when we use
Line 720: # getFreeMetadataSlot to avoid a race between getting the occupied
sorry, I do not understand this TODO. The suggested code takes the
lock for
We'll have to get Federico to weigh in on it.
Line 721: # metadata slots and tagging the new LV (commit to the new slot).
Line 722: with self._lvTagMetaSlotLock:
Line 723: if self.getVersion() in VERS_METADATA_LV:
Line 724: yield self.getVolumeMetadataOffsetFromPvMapping(vol_name)
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
12:02 p.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
Adam Litke has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
12:03 p.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
Adam Litke has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Patch Set 6: -Code-Review
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:04 a.m.
New subject: Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot
Nir Soffer has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/25988/6/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 716:
Line 717: @contextmanager
Line 718: def getVolumeMetadataSlot(self, vol_name, slotSize):
Line 719: # TODO: _lvTagMetaSlotLock should be relevant only when we use
Line 720: # getFreeMetadataSlot to avoid a race between getting the occupied
We'll have to get Federico to weigh in on it.
Seems that
_lvTagMetaSlotLock should be used only when using getFreeMetadataSlot(), and not when
using getVolumeMetadataOffsetFromPvMapping().
When calling getFreeMetaDataSlot(), we must prevent adding or removing new slots when we
search for the occupied ones.
When calling getVolumeMetadataOffsetFromPvMapping() we seems to use the slot according to
the pv layout which cannot change, and mysterious "mapoffset" value which I
don't fully understand, added in downstream d282ec2e (BZ#675683, BZ#684584, BZ#664432
- Metadata refactoring).
I would replace the TODO with: "Check if the lock is needed when using
getVolumeMetadataOffsetFromPvMapping()", but I would not touch this code since it had
no tests, no documentation, and too many "tricks".
Line 721: # metadata slots and tagging the new LV (commit to the new slot).
Line 722: with self._lvTagMetaSlotLock:
Line 723: if self.getVersion() in VERS_METADATA_LV:
Line 724: yield self.getVolumeMetadataOffsetFromPvMapping(vol_name)
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
1:34 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
automation(a)ovirt.org has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:37 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
automation(a)ovirt.org has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:58 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16550/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16721/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_el_gerrit/15751/ : SUCCESS
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:24 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16558/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16729/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_el_gerrit/15759/ : FAILURE
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:35 a.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
automation(a)ovirt.org has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:34 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16723/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16895/ : SUCCESS
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:46 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
automation(a)ovirt.org has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:48 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16811/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16983/ : SUCCESS
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:54 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
automation(a)ovirt.org has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:20 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16845/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17017/ : SUCCESS
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:49 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
automation(a)ovirt.org has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:49 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 12:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16969/
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:14 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 12:
Build Started (2/2) ->
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17142/
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:17 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 12:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16969/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17142/ : FAILURE
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:38 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
automation(a)ovirt.org has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:38 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 13:
Build Started (1/2) ->
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17222/
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:38 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 13:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17048/
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:41 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
Adam Litke has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 13: Verified+1
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:41 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 13:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17048/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17222/ : FAILURE
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:59 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
automation(a)ovirt.org has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:59 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 14:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17556/
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:59 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 14:
Build Started (2/2) ->
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17730/
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:02 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17556/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17730/ : SUCCESS
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:55 a.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
Nir Soffer has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 14:
(2 comments)
We have two changes here:
- Moving the metadata lock from blockVolume to blockSD - this is better since blockSD is
managing the metadata slots.
- Hiding the lock in a context manager - safer but strange api - we should review this
later to make it more clear.
Do yo like to separate the changes?
https://gerrit.ovirt.org/#/c/25988/14/tests/volumeTests.py
File tests/volumeTests.py:
Line 97:
Line 98: def testMetaSlotLock(self):
Line 99: with self.blksd.getVolumeMetadataSlot(None, 1):
Line 100: lktaken = self.blksd._lvTagMetaSlotLock.acquire(False)
Line 101: self.assertEqual(lktaken, False)
lktaken -> acquired
https://gerrit.ovirt.org/#/c/25988/14/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 714:
Line 715: _lvTagMetaSlotLock = threading.Lock()
Line 716:
Line 717: @contextmanager
Line 718: def getVolumeMetadataSlot(self, vol_name, slotSize):
Calling it like a getter is confusing:
slot = domain.getVolumeMetadataSlot(vol, size)
The code looks right, but it is wrong.
Maybe this will be little more clear?
with domain.acquireMetadataSlot(vol, size) as slot:
...
Line 719: # TODO: _lvTagMetaSlotLock should be relevant only when we use
Line 720: # getFreeMetadataSlot to avoid a race between getting the occupied
Line 721: # metadata slots and tagging the new LV (commit to the new slot).
Line 722: with self._lvTagMetaSlotLock:
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
8:12 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
automation(a)ovirt.org has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:12 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 15:
Build Started (1/2) ->
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17903/
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:12 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 15:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17732/
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:15 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17903/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17732/ : SUCCESS
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:22 a.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
Adam Litke has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 14:
(2 comments)
https://gerrit.ovirt.org/#/c/25988/14/tests/volumeTests.py
File tests/volumeTests.py:
Line 97:
Line 98: def testMetaSlotLock(self):
Line 99: with self.blksd.getVolumeMetadataSlot(None, 1):
Line 100: lktaken = self.blksd._lvTagMetaSlotLock.acquire(False)
Line 101: self.assertEqual(lktaken, False)
lktaken -> acquired
Done
https://gerrit.ovirt.org/#/c/25988/14/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 714:
Line 715: _lvTagMetaSlotLock = threading.Lock()
Line 716:
Line 717: @contextmanager
Line 718: def getVolumeMetadataSlot(self, vol_name, slotSize):
Calling it like a getter is confusing:
Done
Line 719: # TODO: _lvTagMetaSlotLock should be relevant only when we use
Line 720: # getFreeMetadataSlot to avoid a race between getting the occupied
Line 721: # metadata slots and tagging the new LV (commit to the new slot).
Line 722: with self._lvTagMetaSlotLock:
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
10:22 a.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
Adam Litke has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/25988/6/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 716:
Line 717: @contextmanager
Line 718: def getVolumeMetadataSlot(self, vol_name, slotSize):
Line 719: # TODO: _lvTagMetaSlotLock should be relevant only when we use
Line 720: # getFreeMetadataSlot to avoid a race between getting the occupied
Seems that _lvTagMetaSlotLock should be used only when using
getFreeMetadat
Done
Line 721: # metadata slots and tagging the new LV (commit to the new slot).
Line 722: with self._lvTagMetaSlotLock:
Line 723: if self.getVersion() in VERS_METADATA_LV:
Line 724: yield self.getVolumeMetadataOffsetFromPvMapping(vol_name)
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
3:47 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
automation(a)ovirt.org has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:47 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 16:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18303/
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:47 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 16:
Build Started (2/2) ->
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1533/
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18303/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1533/ : SUCCESS
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:04 a.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
Adam Litke has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 16: Verified+1
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
12:35 p.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
Nir Soffer has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 16: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
10:18 a.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
Dan Kenigsberg has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 16: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
10:18 a.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
Dan Kenigsberg has submitted this change and it was merged.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
block: convert getVolumeMetadataSlot into a contexmanager
Using a contextmanager on getVolumeMetadataSlot allows us to hide the
metadata slot lock inside the StorageDomain object instead of having to
use it from other modules (e.g. formatConverter).
Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/25988
Tested-by: Adam Litke <alitke(a)redhat.com>
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/volumeTests.py
M vdsm/storage/blockSD.py
M vdsm/storage/blockVolume.py
M vdsm/storage/imageRepository/formatConverter.py
4 files changed, 25 insertions(+), 17 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Adam Litke: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10:18 a.m.
New subject: Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager
automation(a)ovirt.org has posted comments on this change.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
Patch Set 17:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
3293
days inactive
3703
days old
vdsm-patches@lists.fedorahosted.org
61 comments
7 participants
participants (7)
-
alitke＠redhat.com -
automation＠ovirt.org -
Dan Kenigsberg -
Federico Simoncelli -
iheim＠redhat.com -
Jenkins CI RO -
Nir Soffer