Dan Kenigsberg has submitted this change and it was merged.
Change subject: block: convert getVolumeMetadataSlot into a contexmanager
......................................................................
block: convert getVolumeMetadataSlot into a contexmanager
Using a contextmanager on getVolumeMetadataSlot allows us to hide the
metadata slot lock inside the StorageDomain object instead of having to
use it from other modules (e.g. formatConverter).
Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Reviewed-on:
https://gerrit.ovirt.org/25988
Tested-by: Adam Litke <alitke(a)redhat.com>
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/volumeTests.py
M vdsm/storage/blockSD.py
M vdsm/storage/blockVolume.py
M vdsm/storage/imageRepository/formatConverter.py
4 files changed, 25 insertions(+), 17 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Adam Litke: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/25988
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1496238ea4f9a1902f816b20959ce3379e87871
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org