7:55 p.m.
Hi,
Not sure if anyone else has run into this issue, but I thought I'd report
back just in case someone does.
Issuing a "cobbler status" to see when systems were installed did not work
for me with the following error:
Tue Apr 17 10:41:09 2012 - INFO | Exception occured: <type
'exceptions.ValueError'>
Tue Apr 17 10:41:09 2012 - INFO | Exception value: too many values to unpack
Tue Apr 17 10:41:09 2012 - INFO | Exception Info:
File "/usr/lib/python2.6/site-packages/cobbler/remote.py", line 1948, in
_dispatch
return method_handle(*params)
File "/usr/lib/python2.6/site-packages/cobbler/remote.py", line 1598, in
get_status
return self.api.status(mode=mode)
File "/usr/lib/python2.6/site-packages/cobbler/api.py", line 739, in
status
return statusifier.run()
File "/usr/lib/python2.6/site-packages/cobbler/action_status.py", line
166, in run
self.scan_logfiles()
File "/usr/lib/python2.6/site-packages/cobbler/action_status.py", line
74, in scan_logfiles
(profile_or_system, name, ip, start_or_stop, ts) = tokens
"tokens" is a list that contains the elements of each line from
/var/log/cobbler/install.log* split by whitespace. The code in
action_status.py expects the lines in install.log to look like this:
system cobblertest None start 1334622964.41
If you are upgrading from 2.0.x to 2.2.x, you will likely have install.log
entries like:
system cobblertest None stop 14/03/2012 15:15:52
As you can see, there has been a change in timestamps, so Python freaks out
in line 74 when it finds more values in the "tokens" list than it expected.
The way I fixed it was by simply removing old install.log entries that used
the human-readable date/time. Of course, it could have been fixed by
processing each file and converting to timestamp, but I personally don't
care about the old install entries so it was quicker to delete them.
Perhaps the better fix is to update action_status.py so it can detect the
older format and do it for you, that way one less hiccup in the upgrade.
Lastly, my /etc/logrotate.conf is configured to compress log files, which
means I have a few /var/log/install.log-YYYYMMDD*.gz* files. Clearly the
code in action_status.py is not designed to handled gzipped install.log
files. Should this condition be taken care of by the cobbler code or should
install.log files not be gzipped?
- Gonzalo
8:40 p.m.
On Mon, Apr 16, 2012 at 7:55 PM, Gonzalo Servat
<gonzalo.servat(a)sirca.org.au> wrote:
Hi,
Not sure if anyone else has run into this issue, but I thought I'd report
back just in case someone does.
Issuing a "cobbler status" to see when systems were installed did not work
for me with the following error:
Tue Apr 17 10:41:09 2012 - INFO | Exception occured: <type
'exceptions.ValueError'>
Tue Apr 17 10:41:09 2012 - INFO | Exception value: too many values to unpack
Tue Apr 17 10:41:09 2012 - INFO | Exception Info:
File "/usr/lib/python2.6/site-packages/cobbler/remote.py", line 1948, in
_dispatch
return method_handle(*params)
File "/usr/lib/python2.6/site-packages/cobbler/remote.py", line 1598, in
get_status
return self.api.status(mode=mode)
File "/usr/lib/python2.6/site-packages/cobbler/api.py", line 739, in
status
return statusifier.run()
File "/usr/lib/python2.6/site-packages/cobbler/action_status.py", line
166, in run
self.scan_logfiles()
File "/usr/lib/python2.6/site-packages/cobbler/action_status.py", line
74, in scan_logfiles
(profile_or_system, name, ip, start_or_stop, ts) = tokens
"tokens" is a list that contains the elements of each line from
/var/log/cobbler/install.log* split by whitespace. The code in
action_status.py expects the lines in install.log to look like this:
system cobblertest None start 1334622964.41
If you are upgrading from 2.0.x to 2.2.x, you will likely have install.log
entries like:
system cobblertest None stop 14/03/2012 15:15:52
As you can see, there has been a change in timestamps, so Python freaks out
in line 74 when it finds more values in the "tokens" list than it expected.
The way I fixed it was by simply removing old install.log entries that used
the human-readable date/time. Of course, it could have been fixed by
processing each file and converting to timestamp, but I personally don't
care about the old install entries so it was quicker to delete them. Perhaps
the better fix is to update action_status.py so it can detect the older
format and do it for you, that way one less hiccup in the upgrade.
Is that 2.2.1-1? I'm running of the master branch and don't see that traceback:
# cobbler status
ip |target |start |state
192.168.x.x |system:sl6test |Sun Mar 25 21:10:55 2012|finished
Lastly, my /etc/logrotate.conf is configured to compress log files,
which
means I have a few /var/log/install.log-YYYYMMDD.gz files. Clearly the code
in action_status.py is not designed to handled gzipped install.log files.
Should this condition be taken care of by the cobbler code or should
install.log files not be gzipped?
I believe (not verified) it will just fail to open those, and won't be
reported in the status. Not a problem if you don't mind older systems
not showing up in the status.
8:53 p.m.
On Tue, Apr 17, 2012 at 11:40 AM, James Cammarata <jimi(a)sngx.net> wrote:
Is that 2.2.1-1? I'm running of the master branch and don't see that
traceback:
# cobbler status
ip |target |start |state
192.168.x.x |system:sl6test |Sun Mar 25 21:10:55 2012|finished
Yes, this is 2.2.1-1. Have you checked your action_status.py code to see if
it looks the same as mine in the output? If it is the same, then it should
break if any of your install.log files show human readable date/time.
I believe (not verified) it will just fail to open those, and
won't be
reported in the status. Not a problem if you don't mind older systems
not showing up in the status.
OK, fair enough, I haven't actually tried so I'm not sure how it would
react with .gz files. Either way, I've added a /etc/logrotate.d/cobbler
entry to not compress install.log* files.
- Gonzalo
9:06 p.m.
On Mon, Apr 16, 2012 at 8:53 PM, Gonzalo Servat
<gonzalo.servat(a)sirca.org.au> wrote:
On Tue, Apr 17, 2012 at 11:40 AM, James Cammarata
<jimi(a)sngx.net> wrote:
>
>
> Is that 2.2.1-1? I'm running of the master branch and don't see that
> traceback:
>
> # cobbler status
> ip |target |start |state
> 192.168.x.x |system:sl6test |Sun Mar 25 21:10:55 2012|finished
Yes, this is 2.2.1-1. Have you checked your action_status.py code to see if
it looks the same as mine in the output? If it is the same, then it should
break if any of your install.log files show human readable date/time.
Yes mine looks the same, and my install.log contains the epoch time
stamp (not the formated one you had). Can you check the
cobbler/modules/install_{pre,post}_log.py files on your system? They
look like this in the master branch:
fd = open("/var/log/cobbler/install.log","a+")
fd.write("%s\t%s\t%s\tstart\t%s\n" % (objtype,name,ip,time.time()))
fd.close()
9:10 p.m.
On Tue, Apr 17, 2012 at 12:06 PM, James Cammarata <jimi(a)sngx.net> wrote:
Yes mine looks the same, and my install.log contains the epoch time
stamp (not the formated one you had). Can you check the
cobbler/modules/install_{pre,post}_log.py files on your system? They
look like this in the master branch:
fd = open("/var/log/cobbler/install.log","a+")
fd.write("%s\t%s\t%s\tstart\t%s\n" % (objtype,name,ip,time.time()))
fd.close()
Ah, here we go. Cobbler 2.0.x used:
fd.write("%s\t%s\t%s\tstop\t%s\t%s\n" % (objtype, name, ip, dns,
time.strftime("%d/%m/%Y %H:%M:%S")))
... which explains why my install.log files had formatted times. Problem is
that "cobbler status" in Cobbler 2.2.x is not prepared to process
install.log files with formatted times.
- Gonzalo
9:32 p.m.
On Mon, Apr 16, 2012 at 9:10 PM, Gonzalo Servat
<gonzalo.servat(a)sirca.org.au> wrote:
On Tue, Apr 17, 2012 at 12:06 PM, James Cammarata
<jimi(a)sngx.net> wrote:
>
> Yes mine looks the same, and my install.log contains the epoch time
> stamp (not the formated one you had). Can you check the
> cobbler/modules/install_{pre,post}_log.py files on your system? They
> look like this in the master branch:
>
> fd = open("/var/log/cobbler/install.log","a+")
> fd.write("%s\t%s\t%s\tstart\t%s\n" % (objtype,name,ip,time.time()))
> fd.close()
Ah, here we go. Cobbler 2.0.x used:
fd.write("%s\t%s\t%s\tstop\t%s\t%s\n" % (objtype, name, ip, dns,
time.strftime("%d/%m/%Y %H:%M:%S")))
... which explains why my install.log files had formatted times. Problem is
that "cobbler status" in Cobbler 2.2.x is not prepared to process
install.log files with formatted times.
Interesting, if that's true it was changed a LONG time ago:
defe28ec (Michael DeHaan 2009-02-12 18:14:24 -0500 28) \
fd.write("%s\t%s\t%s\tstart\t%s\n" % (objtype,name,ip,time.time()))
Frankly I'd just archive your existing log files and start from
scratch (or write a quick shell script to convert them).
9:48 p.m.
On Tue, Apr 17, 2012 at 12:32 PM, James Cammarata <jimi(a)sngx.net> wrote:
Interesting, if that's true it was changed a LONG time ago:
defe28ec (Michael DeHaan 2009-02-12 18:14:24 -0500 28) \
fd.write("%s\t%s\t%s\tstart\t%s\n" % (objtype,name,ip,time.time()))
Frankly I'd just archive your existing log files and start from
scratch (or write a quick shell script to convert them).
Yep, that's exactly what I did.
- Gonzalo
4413
days inactive
4413
days old
cobbler@lists.fedorahosted.org
6 comments
2 participants
participants (2)
-
Gonzalo Servat -
James Cammarata