10:21 p.m.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=503250
Jens Petersen <petersen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #21 from Jens Petersen <petersen(a)redhat.com> 2010-08-31 23:21:53 EDT
---
Here is the review:
+:ok, !:needs attention, -:needs fixing, NA: not applicable
MUST Items:
[!] MUST: rpmlint output
ghc-hinotify.src: W: spelling-error Summary(en_US) Haskell -> Gaskell,
Gaitskell, Skellum
ghc-hinotify.src: W: strange-permission hinotify-0.3.1.tar.gz 0640L
ghc-hinotify.src: W: strange-permission ghc-hinotify.spec 0640L
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Please fix the strange-permission's before importing.
ghc-hinotify.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell,
Gaitskell, Skellum
ghc-hinotify.x86_64: W: executable-stack
/usr/lib64/ghc-6.12.1/hinotify-0.3.1/libHShinotify-0.3.1-ghc6.12.1.so
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
ghc-hinotify-devel.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell,
Gaitskell, Skellum
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
ghc-hinotify-prof.x86_64: E: devel-dependency ghc-hinotify-devel
ghc-hinotify-prof.x86_64: W: no-documentation
ghc-hinotify-prof.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/ghc-6.12.1/hinotify-0.3.1/libHShinotify-0.3.1_p.a
1 packages and 0 specfiles checked; 1 errors, 2 warnings.
All standard and waived
[+] MUST: Package Naming Guidelines
[+] MUST: spec file name must match base package %{name}
[+] MUST: Packaging Guidelines.
[+] MUST: Licensing Guidelines
[+] MUST: License field in the package spec file must match actual license.
[+] MUST: include license files in %doc if available in source
[+] MUST: The spec file must be written in American English and be legible.
[+] MUST: source md5sum matches upstream release
b24191dab428cd0bfb74af9f0ab68372 hinotify-0.3.1.tar.gz
[+] MUST: must successfully compile and build into binary rpms on one main arch
http://koji.fedoraproject.org/koji/taskinfo?taskID=2439099
[+] MUST: if necessary use ExcludeArch for other archs
[+] MUST: All build dependencies must be listed in BuildRequires
[NA] MUST: use %find_lang macro for .po translations
[NA] MUST: packages which store shared library files in the dynamic linker's
default paths, must call ldconfig in %post and %postun.
[NA] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review
[+] MUST: A package must own all directories that it creates.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Every %files section must
include a %defattr(...) line.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissable content.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Header files must be in a -devel package.
[NA] MUST: Static libraries must be in a -static package.
[NA] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[+] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency
[+] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.
SHOULD Items:
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[+] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
Package is APPROVED
Please fix the above file permissions before importing into SCM.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.