Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: tomoe-gtk not built with $RPM_OPT_FLAGS
https://bugzilla.redhat.com/show_bug.cgi?id=499880
Summary: tomoe-gtk not built with $RPM_OPT_FLAGS Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Keywords: Patch Severity: medium Priority: low Component: tomoe-gtk AssignedTo: dchen@redhat.com ReportedBy: ville.skytta@iki.fi QAContact: extras-qa@fedoraproject.org CC: ryo-dairiki@users.sourceforge.net, dchen@redhat.com, fedora-i18n-bugs@redhat.com Blocks: 496968 Estimated Hours: 0.0 Classification: Fedora
Created an attachment (id=343135) --> (https://bugzilla.redhat.com/attachment.cgi?id=343135) Build with $RPM_OPT_FLAGS
Fix attached, see bug 496968 for more info.
I think this is quite obviously an upstream bug; a corresponding patch to macros/python.m4 should be submitted there.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
Ding-Yi Chen dchen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
--- Comment #1 from Ding-Yi Chen dchen@redhat.com 2009-05-15 02:34:01 EDT --- Thanks for informing me and providing patch for this bug. However, I tend not to apply patches on generated sources. Anyway, I will submit the patch to the upstream.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
--- Comment #2 from Fedora Update System updates@fedoraproject.org 2009-05-15 02:40:33 EDT --- tomoe-gtk-0.6.0-7.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/tomoe-gtk-0.6.0-7.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
--- Comment #3 from Fedora Update System updates@fedoraproject.org 2009-05-15 02:40:37 EDT --- tomoe-gtk-0.6.0-7.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/tomoe-gtk-0.6.0-7.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #4 from Fedora Update System updates@fedoraproject.org 2009-05-15 19:26:34 EDT --- tomoe-gtk-0.6.0-7.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update tomoe-gtk'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-4984
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2009-05-15 19:31:38 EDT --- tomoe-gtk-0.6.0-7.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update tomoe-gtk'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-5022
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2009-06-30 17:22:09 EDT --- tomoe-gtk-0.6.0-7.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |0.6.0-7.fc10 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2009-06-30 17:29:48 EDT --- tomoe-gtk-0.6.0-7.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.6.0-7.fc10 |0.6.0-7.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
Ville Skyttä ville.skytta@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Reopened Status|CLOSED |ASSIGNED Resolution|ERRATA |
--- Comment #9 from Ville Skyttä ville.skytta@iki.fi 2009-07-08 12:42:04 EDT --- (In reply to comment #1)
Thanks for informing me and providing patch for this bug. However, I tend not to apply patches on generated sources. Anyway, I will submit the patch to the upstream.
Hmm, was your intention to drop the patch altogether or create a corresponding one for non-generated sources? The package is not currently built with $RPM_OPT_FLAGS even though the changelog entries for 0.6.0-6 and 0.6.0-7 say so -> reopening.
http://kojipkgs.fedoraproject.org/packages/tomoe-gtk/0.6.0/7.fc11/data/logs/...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-07-13 00:48:01 EDT --- tomoe-gtk-0.6.0-8.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/tomoe-gtk-0.6.0-8.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2009-07-13 00:48:06 EDT --- tomoe-gtk-0.6.0-8.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/tomoe-gtk-0.6.0-8.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
--- Comment #12 from Ville Skyttä ville.skytta@iki.fi 2009-07-15 12:20:33 EDT --- The bug is still not fixed; the only changes between -7.fc* and -8.fc* are cosmetic. See comment 9.
http://cvs.fedoraproject.org/viewvc/rpms/tomoe-gtk/F-11/tomoe-gtk.spec?r1=1.... http://kojipkgs.fedoraproject.org/packages/tomoe-gtk/0.6.0/8.fc11/data/logs/...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
--- Comment #13 from Ding-Yi Chen dchen@redhat.com 2009-07-16 03:54:20 EDT --- Sorry, I forgot to add back the Buildrequire: autoconf, automake
http://koji.fedoraproject.org/koji/taskinfo?taskID=1477780
Does it works for you now?
Regards,
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
--- Comment #14 from Ville Skyttä ville.skytta@iki.fi 2009-07-16 10:39:48 EDT --- No, it's still not fixed. Again, please see comment 9: you have dropped the part of my original patch that actually fixes the problem of CFLAGS being discarded:
python_disable_message="Disable Python binding." + _SAVE_CFLAGS="$CFLAGS" CFLAGS="$CFLAGS $PYTHON_CFLAGS"
It's easy to verify from the build logs whether $RPM_OPT_FLAGS are in use, for example the first gcc line from http://koji.fedoraproject.org/koji/getfile?taskID=1477780&name=build.log:
/bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/tomoe -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -DSYSCONFDIR=""/etc"" -DDATADIR=""/usr/share"" -DTOMOEGTKDATADIR=""/usr/share"/tomoe-gtk" -c -o tomoe-canvas.lo tomoe-canvas.c
There are no $RPM_OPT_FLAGS in it. There should be stuff like "-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector ..."
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2009-07-19 06:27:08 EDT --- tomoe-gtk-0.6.0-8.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update tomoe-gtk'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7771
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2009-07-19 06:36:24 EDT --- tomoe-gtk-0.6.0-8.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update tomoe-gtk'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-7791
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
--- Comment #17 from Fedora Update System updates@fedoraproject.org 2009-08-09 22:07:08 EDT --- tomoe-gtk-0.6.0-11.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/tomoe-gtk-0.6.0-11.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
--- Comment #18 from Fedora Update System updates@fedoraproject.org 2009-08-09 22:07:13 EDT --- tomoe-gtk-0.6.0-11.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/tomoe-gtk-0.6.0-11.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
--- Comment #19 from Fedora Update System updates@fedoraproject.org 2009-08-10 17:38:49 EDT --- tomoe-gtk-0.6.0-11.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update tomoe-gtk'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8411
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
--- Comment #20 from Fedora Update System updates@fedoraproject.org 2009-08-10 17:54:08 EDT --- tomoe-gtk-0.6.0-11.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update tomoe-gtk'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8448
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
--- Comment #21 from Fedora Update System updates@fedoraproject.org 2009-08-31 19:42:41 EDT --- tomoe-gtk-0.6.0-11.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version|0.6.0-7.fc11 |0.6.0-11.fc10 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
--- Comment #22 from Fedora Update System updates@fedoraproject.org 2009-08-31 19:44:32 EDT --- tomoe-gtk-0.6.0-11.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499880
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.6.0-11.fc10 |0.6.0-11.fc11
i18n-bugs@lists.fedoraproject.org