https://bugzilla.redhat.com/show_bug.cgi?id=2275556
--- Comment #8 from Kan-Ru Chen <kanru(a)kanru.info> ---
(In reply to Sandro from comment #5)
[ ]: Development files must be in a -devel package
=> No devel sub package provided. Not sure if it makes sense for this
package, but there are some header files.
This makes sense. It is only an end user application.
[!]: Latest version is packaged.
=> Upstream has released version 0.2.3, please update before importing
Yeah, I didn't expect them to release a new version but it seems like my
upstream
PR nudged them. I'll import the new version.
[!]: %check is present and all tests pass.
=> Upstream doesn't provide any tests. Would be nice if they were. Not
blocking the review, though.
+1
[!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see
attached diff).
=> Not a problem. This is the usual rpmautospec expansion happening.
[!] ibus-array.x86_64: E: zero-length /usr/share/doc/ibus-array/NEWS
=> I think upstream decided to use `Changelog` instead. Please remove `NEWS`
from %files. No point in including empty files.
Will do.
[!] ibus-array.x86_64: E: non-executable-script
/usr/share/ibus-array/setup/main.py 644 /usr/bin/env python3
=> Please ensure the file is executable and uses the proper Python shebang.
See:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_shebangs
Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2275556
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...