Notification time stamped 2020-12-01 20:17:24 UTC
=========================================
#ansible-community: Ansible PR review day
=========================================
Meeting started by gundalow at 15:00:13 UTC. The full logs are available
at
https://meetbot.fedoraproject.org/ansible-community/2020-12-01/ansible_pr...
.
Meeting summary
---------------
* Intros (gundalow, 15:00:20)
* What's this all about
https://github.com/ansible/community/issues/407 (gundalow,
15:02:23)
* If you are new to the Ansible Community I invite you to review the
Code of Conduct
https://docs.ansible.com/ansible/latest/community/code_of_conduct.html
(gundalow, 15:02:46)
* this is the (long over due) 2nd PR review day since Collections have
been in place. To start with we will be looking at
`community.general` and `community.network`, `community.aws`
(gundalow, 15:05:08)
* LINK:
https://github.com/ansible-collections/community.general/pulls
(dmsimard, 15:09:19)
* LINK:
https://github.com/ansible-collections/community.network/pulls
(dmsimard, 15:09:24)
* LINK:
https://github.com/ansible-collections/community.aws/pulls
(dmsimard, 15:09:29)
* LINK:
https://github.com/ansible-collections/community.vmware/pulls
(dmsimard, 15:09:39)
* community.general (gundalow, 15:10:14)
* LINK:
https://github.com/ansible-collections/community.general/pulls?q=is%3Apr+...
(gundalow, 15:10:23)
* LINK:
https://github.com/ansible-collections/community.general/pull/53
(gundalow, 15:10:40)
* LINK:
https://github.com/ansible-collections/community.general/pull/53 |
open, created 2020-03-26T09:52:00Z by matbu: Add pacemaker_resource
module for managing cluster resources
[affects_1,bug,ci_verified,module,needs_info,needs_revision,new_contributor,new_module,new_plugin,pr_day,stale_ci]
(github-linkbot, 15:10:41)
* ACTION: dmsimard to ping matbu wrt community.general#53 (gundalow,
15:15:42)
* LINK:
https://github.com/ansible-collections/community.general/pull/85
(gundalow, 15:15:58)
* LINK:
https://github.com/ansible-collections/community.general/pull/85 |
open, created 2020-03-31T13:45:37Z by Shaps: [WIP] Refactor github*
modules,Added tests for github_deploy_key
[WIP,affects_1,bug,ci_verified,deprecated,docs_fragments,integration,module,module_utils,needs_info,needs_rebase,new_plugin,pr_day,stale_ci,tests]
(github-linkbot, 15:15:59)
* ACTION: gundalow to ping shaps wrt community.general#85 (github
modules) (gundalow, 15:17:17)
* ACTION: We need to define some standard language (and add to
templates) along the lines of "we're closing this but if there's
still interest in submitting and maintaining this module, please
reopen and we'll gladly continue the review" (gundalow, 15:20:01)
* LINK:
https://github.com/ansible/ansible/issues/71860 here's an
example of needs_info closing an issue (felixfontein, 15:22:29)
* ACTION: Full review of needs_info inc if the ball is with author or
reviewer. (gundalow, 15:25:38)
* LINK:
https://github.com/ansible-collections/community.general/pull/155
(gundalow, 15:26:04)
* ACTION: Full review of needs_info & needs_revision inc if the ball
is with author or reviewer. (gundalow, 15:27:06)
* LINK:
https://github.com/ansible-collections/community.general/pull/155
(gundalow, 15:27:23)
* LINK:
https://github.com/ansible-collections/community.general/pull/155 |
open, created 2020-04-12T08:27:25Z by xiangge: New module to support
bugzilla
[affects_1,feature,module,needs_revision,new_contributor,new_module,new_plugin,stale_ci,tests,web_infrastructure]
(github-linkbot, 15:27:24)
* LINK:
https://github.com/ansible-collections/community.general/pull/175
(gundalow, 15:32:56)
* LINK:
https://github.com/ansible-collections/community.general/pull/175 |
open, created 2020-04-13T19:49:58Z by achauvinhameau: add
EfficientIP Device Manager dynamic inventory
[affects_1,inventory,needs_revision,new_contributor,new_plugin,pr_day,stale_ci]
(github-linkbot, 15:32:57)
* LINK:
https://github.com/ansible-collections/community.general/pull/219
(gundalow, 15:35:39)
* LINK:
https://github.com/ansible-collections/community.general/pull/219 |
open, created 2020-04-22T12:29:38Z by traittinen: New Infoblox
lookup plugin: nios_next_vlanid
[affects_1,community_review,lookup,new_contributor,new_plugin,stale_ci]
(github-linkbot, 15:35:40)
* started with 76 open PRs in community.general (gundalow, 15:36:40)
* LINK:
https://github.com/ansible-collections/community.general/pull/263
(gundalow, 15:37:05)
* LINK:
https://github.com/ansible-collections/community.general/pull/263 |
open, created 2020-05-02T17:17:10Z by imjoseangel: New merge lists
plugin from a given key
[affects_1,community_review,feature,integration,lookup,new_plugin,pr_day,stale_ci,tests]
(github-linkbot, 15:37:05)
* LINK:
https://github.com/ansible-collections/community.general/pull/604 |
open, created 2020-06-30T19:33:33Z by vbotka: Added filter plugin
lists_mergeby. Fix #249
[affects_2.10,community_review,feature,integration,needs_triage,new_contributor,new_plugin,tests]
(github-linkbot, 15:39:29)
* LINK:
https://github.com/ansible-collections/community.general/pull/267
(gundalow, 15:49:55)
* LINK:
https://github.com/ansible-collections/community.general/pull/267 |
open, created 2020-05-03T19:48:29Z by jdufresne: Fixed flatpak
module to accept a list of names to install/uninstall
[affects_1,bug,integration,module,needs_repo,needs_revision,stale_ci,tests]
(github-linkbot, 15:49:56)
* LINK:
https://github.com/ansible-collections/community.general/pull/1246#discus...
(felixfontein, 15:53:52)
* LINK:
https://github.com/ansible-collections/community.general/pull/1246#discus...
| closed, created 2020-11-08T11:36:40Z by TGuimbert: Add
--non-interactive argurment to Flatpak
[affects_2.10,backport-1,bug,community_review,module,new_contributor,os,packaging,plugins]
(github-linkbot, 15:53:52)
* LINK:
https://github.com/ansible-collections/community.general/pull/664 |
open, created 2020-07-17T08:48:03Z by todorinskiz: Add support for
listing secrets to hashi_vault
[affects_2.10,feature,lookup,needs_revision,needs_triage,new_contributor,plugins,stale_ci]
(github-linkbot, 15:54:29)
* LINK:
https://github.com/ansible-collections/community.general/pull/324
(gundalow, 15:58:06)
* LINK:
https://github.com/ansible-collections/community.general/pull/324 |
open, created 2020-05-12T09:35:51Z by riemers: Yum versionlock
support
[affects_1,module,needs_revision,new_contributor,new_module,new_plugin,stale_ci]
(github-linkbot, 15:58:07)
* LINK:
https://github.com/ansible-collections/community.general/pull/1405
(felixfontein, 16:00:02)
* LINK:
https://github.com/ansible-collections/community.general/pull/1405 |
open, created 2020-11-26T21:50:43Z by aminvakil: Newmodule
yum_versionlock
[affects_2.10,community_review,integration,module,needs_triage,new_module,new_plugin,os,packaging,tests]
(github-linkbot, 16:00:03)
* LINK:
https://github.com/ansible-collections/community.general/pull/1405#issuec...
| open, created 2020-11-26T21:50:43Z by aminvakil: Newmodule
yum_versionlock
[affects_2.10,community_review,integration,module,needs_triage,new_module,new_plugin,os,packaging,tests]
(github-linkbot, 16:01:23)
* ACTION: bot pings are insane:
https://github.com/ansible-collections/community.general/pull/1405#issuec...
(gundalow, 16:02:02)
* LINK:
https://github.com/ansible-collections/community.general/pull/1405#issuec...
| open, created 2020-11-26T21:50:43Z by aminvakil: Newmodule
yum_versionlock
[affects_2.10,community_review,integration,module,needs_triage,new_module,new_plugin,os,packaging,tests]
(github-linkbot, 16:02:03)
* LINK:
https://github.com/ansible-collections/community.general/pull/328
(gundalow, 16:02:55)
* LINK:
https://github.com/ansible-collections/community.general/pull/328 |
open, created 2020-05-12T19:40:35Z by gthiemonge: Add gandi_livedns
module
[affects_1,ci_verified,community_review,module,module_utils,new_contributor,new_module,new_plugin,stale_ci]
(github-linkbot, 16:02:55)
* LINK:
https://github.com/ansible-collections/community.general/pull/328 |
open, created 2020-05-12T19:40:35Z by gthiemonge: Add gandi_livedns
module
[affects_1,ci_verified,community_review,module,module_utils,new_contributor,new_module,new_plugin,stale_ci]
(github-linkbot, 16:06:00)
* ACTION: gundalow to contact Gandi and see if they'd be interested in
having their own collection, and include
https://github.com/ansible-collections/community.general/pull/328
(gundalow, 16:07:05)
* LINK:
https://github.com/ansible-collections/community.general/pull/328 |
open, created 2020-05-12T19:40:35Z by gthiemonge: Add gandi_livedns
module
[affects_1,ci_verified,community_review,module,module_utils,new_contributor,new_module,new_plugin,stale_ci]
(github-linkbot, 16:07:05)
* LINK:
https://github.com/ansible-collections/community.general/pull/335
(gundalow, 16:08:31)
* LINK:
https://github.com/ansible-collections/community.general/pull/335 |
open, created 2020-05-13T17:40:12Z by C0rn3j: [icinga2_host.py]
Actually return codes instead of data
[affects_1,bug,community_review,module,new_contributor,stale_ci]
(github-linkbot, 16:08:32)
* ACTION: dericcrago to test 335 (gundalow, 16:18:15)
* LINK:
https://github.com/ansible-collections/community.general/pull/356
(gundalow, 16:18:34)
* LINK:
https://github.com/ansible-collections/community.general/pull/356 |
open, created 2020-05-17T18:21:56Z by AshishVarshneyy: New feature
for logging runtime
[affects_1,callback,community_review,feature,has_issue,new_contributor,new_plugin,stale_ci]
(github-linkbot, 16:18:34)
* LINK:
https://github.com/ansible-collections/community.general/pull/356
(gundalow, 16:18:38)
* LINK:
https://github.com/ansible-collections/community.general/pull/356#issueco...
| open, created 2020-05-17T18:21:56Z by AshishVarshneyy: New feature
for logging runtime
[affects_1,callback,community_review,feature,has_issue,new_contributor,new_plugin,stale_ci]
(github-linkbot, 16:22:04)
* LINK:
https://github.com/ansible-collections/community.general/pull/357
(gundalow, 16:38:30)
* LINK:
https://github.com/ansible-collections/community.general/pull/357 |
open, created 2020-05-18T13:28:16Z by Akasurde: rpm_ostree_pkg: new
module
[affects_1,bug,community_review,module,new_module,new_plugin,stale_ci]
(github-linkbot, 16:38:30)
* LINK:
https://github.com/ansible-collections/community.general/pull/267
works fine. I pulled the PR and did a sudo
/home/baptistemm/Code/venv/ansible-stable/bin/ansible-test
integration flatpak --allow-unsupported --allow-destructive
--allow-root --docker --docker-privileged (baptistemm, 16:46:33)
* LINK:
https://github.com/ansible-collections/community.general/pull/267 |
open, created 2020-05-03T19:48:29Z by jdufresne: Fixed flatpak
module to accept a list of names to install/uninstall
[affects_1,bug,integration,module,needs_rebase,needs_repo,needs_revision,pr_day,stale_ci,tests]
(github-linkbot, 16:46:33)
* LINK:
https://github.com/ansible-community/ansible-build-data/pull/39#issuecomm...
| closed, created 2020-12-01T09:38:10Z by abadger: Add
community.okd, a collection which was broken out of the
community.general collection, for 2.10.4 (github-linkbot, 16:46:35)
* LINK:
https://github.com/ansible-collections/community.general/pull/358
(gundalow, 16:59:58)
* LINK:
https://github.com/ansible-collections/community.general/pull/358 |
open, created 2020-05-18T13:43:36Z by notok: Bugfix: Fix parsing
array values from osx_defaults
[affects_1,bug,community_review,module,new_contributor,small_patch,stale_ci]
(github-linkbot, 16:59:58)
* LINK:
https://github.com/ansible-collections/community.hashi_vault/pull/5
| open, created 2020-11-30T22:55:37Z by briantist: Add FAQ to README
(github-linkbot, 17:03:55)
* LINK:
https://github.com/ansible-collections/community.hashi_vault/pull/6
| open, created 2020-12-01T00:10:41Z by briantist: Use conditional
interpreter for package module in CI (github-linkbot, 17:04:19)
* break (gundalow, 17:13:38)
* LINK:
https://github.com/ansible-collections/community.general/pull/478#issueco...
| open, created 2020-06-08T06:51:18Z by Akasurde: nmcli - Use
'connection.autoconnect' instead of 'autoconnect'
[affects_1,bug,has_issue,module,needs_maintainer,needs_rebase,needs_revision,stale_ci,tests,unit]
(github-linkbot, 17:45:04)
* LINK:
https://github.com/ansible-collections/community.general/pull/1113 |
closed, created 2020-10-17T02:19:17Z by jbronn: nmcli: module
refactor
[affects_2.10,backport-1,community_review,module,net_tools,plugins,tests,unit]
(github-linkbot, 17:46:09)
* LINK:
https://github.com/mattclay/aws-terminator/pull/117 | open,
created 2020-11-25T10:25:58Z by tremble: Increase age_limits on
resources (github-linkbot, 17:55:54)
* community.aws (gundalow, 18:02:45)
* LINK:
https://github.com/ansible-collections/community.aws/pulls?q=is%3Apr+is%3...
(Oldest PR first (gundalow, 18:04:23)
* LINK:
https://github.com/ansible-collections/community.aws/pull/27
(gundalow, 18:04:59)
* LINK:
https://github.com/ansible-collections/community.aws/pull/27 |
open, created 2020-04-07T13:44:27Z by Tyler-2: fix: Don't mark
kstreams changed when no encryption actions taken
[affects_2.10,bug,module,needs_revision,plugins,stale_ci]
(github-linkbot, 18:05:00)
* LINK:
https://github.com/ansible-collections/community.aws/pull/32 -
This feels like the wrong approach to me and iam_user / iam_role
both support attaching managed policies (tremble, 18:15:52)
* LINK:
https://github.com/ansible-collections/community.aws/pull/32 |
open, created 2020-04-08T20:46:59Z by rbobrowicz: add
iam_managed_policy_attachment module
[affects_2.10,community_review,module,needs_triage,new_contributor,new_module,new_plugin,plugins,stale_ci]
(github-linkbot, 18:15:53)
* LINK:
https://github.com/ansible-collections/community.aws/pull/39
(jillr, 18:21:35)
* LINK:
https://github.com/ansible-collections/community.aws/pull/39 |
open, created 2020-04-16T16:09:36Z by TheOptimisticFactory: fix:
Cloudfront distribution now uses provided origin_access_identity
[affects_2.10,bug,integration,module,needs_revision,new_contributor,plugins,stale_ci,tests]
(github-linkbot, 18:21:35)
* LINK:
https://github.com/ansible-collections/community.aws/pull/44
(jillr, 18:35:13)
* LINK:
https://github.com/ansible-collections/community.aws/pull/44 |
open, created 2020-04-21T10:02:20Z by stefanhorning: New
aws_api_gateway_domain module for adding custom domains
[affects_2.10,ci_verified,integration,module,needs_revision,new_module,new_plugin,plugins,stale_ci,tests]
(github-linkbot, 18:35:13)
* LINK:
https://github.com/ansible-collections/community.aws/pull/51
(jillr, 18:38:28)
* LINK:
https://github.com/ansible-collections/community.aws/pull/51 |
open, created 2020-04-23T11:13:00Z by tomwwright:
ec2_imagebuilder_component module and unit tests
[affects_2.10,module,needs_revision,new_contributor,new_module,new_plugin,plugins,stale_ci,tests]
(github-linkbot, 18:38:29)
* LINK:
https://github.com/ansible-collections/community.aws/pull/65
(jillr, 18:40:48)
* LINK:
https://github.com/ansible-collections/community.aws/pull/65 |
open, created 2020-05-05T16:11:53Z by marknet15: dynamodb_table:
boto3, AnsibleAwsModule, billing_mode, point_in_time_recovery and
more
[affects_2.10,bug,has_issue,integration,module,needs_revision,needs_triage,new_contributor,plugins,stale_ci,tests]
(github-linkbot, 18:40:48)
* LINK:
https://github.com/ansible-collections/community.aws/pull/71
(jillr, 18:41:54)
* LINK:
https://github.com/ansible-collections/community.aws/pull/71 |
open, created 2020-05-14T10:11:51Z by stefanhorning: New module for
AWS SES DKIM identity
[affects_2.10,integration,module,needs_rebase,needs_revision,new_module,new_plugin,plugins,stale_ci,tests]
(github-linkbot, 18:41:54)
* LINK:
https://github.com/ansible-collections/community.aws/pull/91
(jillr, 18:46:22)
* LINK:
https://github.com/ansible-collections/community.aws/pull/91 |
open, created 2020-06-07T13:03:35Z by raags: Add validation to
ensure ecs service is deployed successfully
[affects_2.10,community_review,feature,module,needs_triage,new_contributor,plugins,stale_ci]
(github-linkbot, 18:46:23)
* LINK:
https://github.com/ansible-collections/community.aws/pull/95
(jillr, 18:57:28)
* LINK:
https://github.com/ansible-collections/community.aws/pull/95 |
open, created 2020-06-10T22:40:59Z by TylerLubeck: Implement the
list_global_accelerators module
[affects_2.10,module,needs_revision,needs_triage,new_contributor,new_module,new_plugin,plugins,stale_ci]
(github-linkbot, 18:57:29)
* LINK:
https://github.com/ansible-collections/community.aws/pull/100
(jillr, 19:32:57)
* LINK:
https://github.com/ansible-collections/community.aws/pull/100
| open, created 2020-06-16T22:56:47Z by sydoluciani: Adding a new
module - route53_crrs module
[affects_2.10,community_review,module,needs_triage,new_contributor,new_module,new_plugin,plugins,stale_ci]
(github-linkbot, 19:32:58)
Meeting ended at 20:17:24 UTC.
Action Items
------------
* dmsimard to ping matbu wrt community.general#53
* gundalow to ping shaps wrt community.general#85 (github modules)
* We need to define some standard language (and add to templates) along
the lines of "we're closing this but if there's still interest in
submitting and maintaining this module, please reopen and we'll gladly
continue the review"
* Full review of needs_info inc if the ball is with author or reviewer.
* Full review of needs_info & needs_revision inc if the ball is with
author or reviewer.
* bot pings are insane:
https://github.com/ansible-collections/community.general/pull/1405#issuec...
* gundalow to contact Gandi and see if they'd be interested in having
their own collection, and include
https://github.com/ansible-collections/community.general/pull/328
* dericcrago to test 335
Action Items, by person
-----------------------
* dericcrago
* dericcrago to test 335
* dmsimard
* dmsimard to ping matbu wrt community.general#53
* gundalow
* gundalow to ping shaps wrt community.general#85 (github modules)
* gundalow to contact Gandi and see if they'd be interested in having
their own collection, and include
https://github.com/ansible-collections/community.general/pull/328
* **UNASSIGNED**
* We need to define some standard language (and add to templates)
along the lines of "we're closing this but if there's still interest
in submitting and maintaining this module, please reopen and we'll
gladly continue the review"
* Full review of needs_info inc if the ball is with author or
reviewer.
* Full review of needs_info & needs_revision inc if the ball is with
author or reviewer.
* bot pings are insane:
https://github.com/ansible-collections/community.general/pull/1405#issuec...
People Present (lines said)
---------------------------
* gundalow (163)
* jillr (81)
* felixfontein (77)
* dmsimard (69)
* github-linkbot (40)
* tremble (39)
* abadger1999 (25)
* baptistemm (19)
* zodbot (18)
* markuman (18)
* briantist (16)
* jtanner (16)
* samccann (14)
* maxamillion (14)
* nitzmahone (12)
* acozine (12)
* dericcrago (9)
* akasurde (7)
* Goneri (5)
* aminvakil (4)
* actatux (3)
* sgw_ (3)
* GoKEV (2)
* cybette (2)
* mattclay (1)
* gwmngilfen (1)
* lmodemal (1)
Generated by `MeetBot`_ 0.1.4
.. _`MeetBot`:
http://wiki.debian.org/MeetBot
https://meetbot.fedoraproject.org/ansible-community/2020-12-01/ansible_pr...
--
You received this message due to your preference settings at
https://apps.fedoraproject.org/notifications/fmnmeetingminutes.id.fedorap...