-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/69/#review276
-----------------------------------------------------------
Ship it!
I'm going to say ShipIt here and open a bug to figure out why the firewall services
aren't being revoked during decommission.
- Stephen Gallagher
On Sept. 3, 2014, 3:04 p.m., Thomas Woerner wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/69/
-----------------------------------------------------------
(Updated Sept. 3, 2014, 3:04 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.
Repository: rolekit
Description
-------
installFirewall uses the firewall _settings from the role: firewall and firewall_zones
and stores the applied settings in _settings per zone and also for the runtime and
permanant firewalld environment.
uninstallFirewall uses the fw_changes _setting from the role and removed them from the
zones in runtime and permanent firewalld environment, then clears fw_changes and savet it
to _settings again.
updateFirewall calls uninstallFirewall and then installFirewall
_check_property now checks ports to be valid.
Diffs
-----
src/rolekit/server/rolebase.py 95b10c62ff44fbf12d96992bb07fc68d156259ca
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/69/diff/
Testing
-------
Thanks,
Thomas Woerner