Re: Review Request 131: Allow impersonating a different UID/GID in subprocesses

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/131/#review364 ----------------------------------------------------------- src/rolekit/async.py <http://reviewboard-fedoraserver.rhcloud.com/r/131/#comment192> Note that 0 is False in Python. How about (untested) src/rolekit/async.py <http://reviewboard-fedoraserver.rhcloud.com/r/131/#comment193> AFAICS _calling_ the demote() function is superfluous and, to me, confusing; we only need to pass the set_ids callable. src/rolekit/async.py <http://reviewboard-fedoraserver.rhcloud.com/r/131/#comment195> setre[ug]id() to make it explicit that both are changed? src/rolekit/async.py <http://reviewboard-fedoraserver.rhcloud.com/r/131/#comment194> One way to fix: move this check inside set_ids(), and then call Popen(… preexec_fn=set_ids) Another way, more similar to the current code: … and then call Popen(…, preexec_fn=preexec_fn) (change names as you like) - Miloslav Trmac On Led. 20, 2015, 7:12 odp., Stephen Gallagher wrote: