Re: Review Request 229: Add helper to convert systemd unit state

On Nov. 16, 2015, 2:34 p.m., Nils Philippsen wrote: > src/rolekit/dbus_utils.py, lines 296-308 > <http://reviewboard-fedoraserver.rhcloud.com/r/229/diff/1/?file=1199#file1... > > How about: > > ``` > ... > sd2rk_state = { > 'active': RUNNING, > 'inactive': READY_TO_START, > 'activating': STARTING, > 'deactivating': STOPPING, > } > ... > def map_systemd_state(systemd_state): > # If the state is "failed" or anything else not explicitly called > # out here, treat it as being in ERROR state. > return self.sd2rk_state.get(systemd_state, ERROR) > ... > ```

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/229/ ----------------------------------------------------------- (Updated Nov. 10, 2015, 11:25 p.m.) Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- We want to translate ActiveState values to our persistent and transitional states. Diffs ----- src/rolekit/dbus_utils.py a5f5a1d5ee4f32865fca6459615ea3359f3ca11d Diff: http://reviewboard-fedoraserver.rhcloud.com/r/229/diff/ Testing ------- Thanks, Stephen Gallagher