Re: Review Request 62: Add asynchronous helper for calling a subprocess

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/62/ ----------------------------------------------------------- (Updated Aug. 19, 2014, 11:49 a.m.) Status ------ This change has been discarded. Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner. Repository: rolekit Description ------- This will spawn a thread to monitor the subprocess, capture both stdout and stderr and throw an exception if the process terminates with a non-zero error code. Diffs ----- src/rolekit/async.py 1e2b82eab5a4e6862594672f738c1935a83c2be5 Diff: http://reviewboard-fedoraserver.rhcloud.com/r/62/diff/ Testing ------- Manual testing was done by having it call a script that slept for 30s and verifying that other requests could be successfully made to rolekit while it was waiting. This code probably needs a unit test, but I haven't written it yet. Thanks, Stephen Gallagher