On 06/19/2020 03:17 PM, Tomasz Kłoczko wrote:
On Fri, 19 Jun 2020 at 22:20, Ben Cotton <bcotton(a)redhat.com
<mailto:bcotton@redhat.com>> wrote:
[..]
The %make_build macro enables parallel make builds using the -j option. In case a
package does not build correctly with parallel make, then parallel make will be disabled
for that package by redefining the %_smp_mflags macro like this:
%global _smp_mflags -j1
Sometimes only %build or %install or %check is failing.
That's a good point. What if as an alternative as part of
this change, we used %make_build -j1 in the case where
parallel building does not work?
Any -j1 tweaks should be *only temporary* so IMO formalising this
kind of changes is pointless.
All parallel build issues should be treated *as critical bugs* which should be *ASAP
fixed*.
So are you saying that we should not document the %make_build -j1 convention
and instead update the documentation to state that parallel build failures must be
fixed?
Even if we don't document this new convention, I still thing it should
be used for this change, because I think having %make_build -j1 makes it
obvious something is broken and more likely to get fixed.
-Tom
kloczek
--
Tomasz Kłoczko | LinkedIn:
http://lnkd.in/FXPWxH
_______________________________________________
devel mailing list -- devel(a)lists.fedoraproject.org
To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org