On 05/27/2020 05:19 AM, Richard Shaw wrote:
On Tue, May 26, 2020 at 10:12 PM Tom Stellard <tstellar(a)redhat.com
<mailto:tstellar@redhat.com>> wrote:
On 05/21/2020 07:57 AM, Richard Shaw wrote:
> Not really a big deal but %build_make has been available for quite a while. I
noticed a few of my packages still supply _smp_mflags manually.
>
> Is this worth a script and automatic BZ? Probably not, but I think there is an
intrinsic value to consistency.
>
I've been going through and fixing this manually in some spec files.
Do you want to merge these and do the builds?
https://src.fedoraproject.org/rpms/dumpet/pull-request/1
https://src.fedoraproject.org/rpms/byaccj/pull-request/1
https://src.fedoraproject.org/rpms/splix/pull-request/1
https://src.fedoraproject.org/rpms/qiv/pull-request/1
https://src.fedoraproject.org/rpms/tss2/pull-request/8
https://src.fedoraproject.org/rpms/marisa/pull-request/3
https://src.fedoraproject.org/rpms/ldns/pull-request/2
While it's a simple change, we should wait a little a little while and see if the
maintainers respond. Also, it doesn't hurt anything but typically it's
"%make_build / %make_install" without the {}.
These changes were actually submitted a while ago. Some pull requests are
2-3 months old.
Also, I used to use %make_build without the {}, but someone suggested[1] I
add the {} in case the macro ever became a function.
-Tom
[1]
https://src.fedoraproject.org/rpms/perl-Digest-SHA/pull-request/1#comment...
Thanks,
Richard
_______________________________________________
devel mailing list -- devel(a)lists.fedoraproject.org
To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org