Hi Petr, On 08/21/2018 11:50 AM, Petr Šplíchal wrote: > Hi, > > as part of bringing upstream and downstream workflows related to > testing one more step closer together and allow easier automation > tools development and sharing between Fedora, Red Hat Enterprise > Linux and other products, the CI team is proposing to use a > consistent format for the CI related messages: > > https://pagure.io/fedora-ci/messages > > The specification (currently describing koji-build and brew-build > messages) is written in self-documented YAML files defining a > JSON SCHEMA which can be used to validate the message format. > Included is also a set of example messages to get a quick start. > > Please, review the proposed format and share your feedback. > Thanks! I've only skimmed the format and I don't work on anything that consumes these messages, so I can't provide great feedback on that. A couple of quick notes on the schema itself, though:

* "generated_at" is in a human-readable format, but doesn't include the timezone (UTC). It would be nice to include that, or use a machine- readable format and keep it documented as being UTC. You should also be able to enforce this with JSON schema's "date-time" type if you opt to go the human-readable route.

* URLs can be of type "uri" and JSON schema will enforce that.

I'm curious, are you aware of https://fedora-messaging.readthedocs.io/ and generally the plan for Fedora infrastructure to move to AMQP? fedora-messaging uses JSON schema as well and enforces the schema when sending or receiving.

On 08/23/2018 10:57 AM, Petr Šplíchal wrote: > On Tue, 21 Aug 2018 at 15:22, Jeremy Cline <jeremy(a)jcline.org&gt; wrote: > > > * URLs can be of type "uri" and JSON schema will enforce that. > > That for the hint. I've updated schemas to specify format as well > (simply using uri as type did not work): > https://pagure.io/fedora-ci/messages/c/c0cdee9 > Unfortunately it seems "python-jsonschema" does not enforce this. > Ah, that's good to know. > > I'm curious, are you aware of https://fedora-messaging.readthedocs.io/ > > and generally the plan for Fedora infrastructure to move to AMQP? > > fedora-messaging uses JSON schema as well and enforces the schema when > > sending or receiving. > > Didn't know that. Thanks for the pointer! Will have a look. Do you > know what's the time frame when the migration should happen? There's a broker cluster in stg now, and bridges for the ZMQ publishers and subscribers will be set up in the next week or two. Once all the issues discovered there are fixed up we'll set up a production cluster and applications can start to migrate. Optimistically, I'd say mid-September?

On 08/23/2018 01:34 PM, Adam Williamson wrote: > <ADD ANOTHER MONTH JUST ON GENERAL PRINCIPLES> > OUTPUT: "late December" What about <ADD ANOTHER MONTH BECAUSE DECEMBER> OUTPUT: "late January" <ADD ANOTHER MONTH BECAUSE DEVCONF> OUTPUT: "late February"

Hi, as part of bringing upstream and downstream workflows related to testing one more step closer together and allow easier automation tools development and sharing between Fedora, Red Hat Enterprise Linux and other products, the CI team is proposing to use a consistent format for the CI related messages: https://pagure.io/fedora-ci/messages The specification (currently describing koji-build and brew-build messages) is written in self-documented YAML files defining a JSON SCHEMA which can be used to validate the message format. Included is also a set of example messages to get a quick start. Please, review the proposed format and share your feedback. Thanks!

On Tue, 2018-08-21 at 14:18 -0600, Ken Dreyer wrote: > On Tue, Aug 21, 2018 at 4:50 AM, Petr Šplíchal <psplicha(a)redhat.com&gt; wrote: > > Hi, > > > > as part of bringing upstream and downstream workflows related to > > testing one more step closer together and allow easier automation > > tools development and sharing between Fedora, Red Hat Enterprise > > Linux and other products, the CI team is proposing to use a > > consistent format for the CI related messages: > > > > https://pagure.io/fedora-ci/messages > > > > The specification (currently describing koji-build and brew-build > > messages) is written in self-documented YAML files defining a > > JSON SCHEMA which can be used to validate the message format. > > Included is also a set of example messages to get a quick start. > > > > Please, review the proposed format and share your feedback. > > Thanks! > > Are these completely separate from what Koji generates with > https://pagure.io/koji/blob/master/f/plugins/hub/protonmsg.py ? This initiative is specific to messages to do with automated testing, it's not a spec for *all* message bus messages sent by anything ever. It'd mainly be relevant to automated test systems we have in Fedora like the CI pipeline, Taskotron, openQA and autocloud.

On Tue, Aug 21, 2018 at 12:50:57PM +0200, Petr Šplíchal wrote: > Hi, > > as part of bringing upstream and downstream workflows related to > testing one more step closer together and allow easier automation > tools development and sharing between Fedora, Red Hat Enterprise > Linux and other products, the CI team is proposing to use a > consistent format for the CI related messages: > > https://pagure.io/fedora-ci/messages > > The specification (currently describing koji-build and brew-build > messages) is written in self-documented YAML files defining a > JSON SCHEMA which can be used to validate the message format. > Included is also a set of example messages to get a quick start. > > Please, review the proposed format and share your feedback. It was really clear if this refers to emails or some other kind of message. In any case I'd be more than happy if you just fixed the subject lines of emails. Attached is my previous rant on this topic for reference :-)