On 7 December 2016 at 09:39, Jakub Jedelsky <jakub.jedelsky(a)gmail.com&gt; wrote: > Hi there, > > I'm maintainer of vertica-python package and want to add support for > python3, but I'm a little bit lost in naming. > > I named package as a upstream 'vertica-python', because (if I remember > correctly) naming guidelines told, that if upstream has 'python' in > the name it should stay there (can't found the source now). But how > should I name python3 package? Should it be 'python3-vertica-python' > od 'vertica-python3'? > > Or should I rename package to python{3,2}-vertica and obsolete > vertica-python? > > Well the name in setup.py is vertica-python and it installs as vertica_python and the pip install is that as well. So according to the guidelines I'd expect it to by python2-vertica-python and python3-vertica-python even if it sounds a little awkward, best way to handle anything that might end up depending on it etc

_______________________________________________ devel mailing list -- devel(a)lists.fedoraproject.org To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org

On Wed, Dec 07, 2016 at 11:48:55AM +0100, Igor Gnatenko wrote: > On Wed, Dec 7, 2016 at 10:48 AM, James Hogarth <james.hogarth(a)gmail.com&gt; wrote: > > On 7 December 2016 at 09:39, Jakub Jedelsky <jakub.jedelsky(a)gmail.com&gt; wrote: > >> Hi there, > >> > >> I'm maintainer of vertica-python package and want to add support for > >> python3, but I'm a little bit lost in naming. > >> > >> I named package as a upstream 'vertica-python', because (if I remember > >> correctly) naming guidelines told, that if upstream has 'python' in > >> the name it should stay there (can't found the source now). But how > >> should I name python3 package? Should it be 'python3-vertica-python' > >> od 'vertica-python3'? > >> > >> Or should I rename package to python{3,2}-vertica and obsolete > >> vertica-python? > >> > >> > > > > Well the name in setup.py is vertica-python and it installs as > > vertica_python and the pip install is that as well. > > > > So according to the guidelines I'd expect it to by > > python2-vertica-python and python3-vertica-python even if it sounds a > > little awkward, best way to handle anything that might end up > > depending on it etc > IMO this is worst thing. I think having pythonX-vertica is better. I just sniffed around repos and found just one package with a weird name - it's python3-python-etcd. On the other hand I found a few, which are in style <name>-python3, e.g. abrt-python3, libvirt-python3. So it looks, that this naming should be quite good.

- jj _______________________________________________ devel mailing list -- devel(a)lists.fedoraproject.org To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org

On 7 December 2016 at 13:07, Jakub Jedelsky <jakub.jedelsky(a)gmail.com&gt; wrote: > On Wed, Dec 07, 2016 at 11:48:55AM +0100, Igor Gnatenko wrote: >> On Wed, Dec 7, 2016 at 10:48 AM, James Hogarth <james.hogarth(a)gmail.com&gt; wrote: >> > On 7 December 2016 at 09:39, Jakub Jedelsky <jakub.jedelsky(a)gmail.com&gt; wrote: >> >> Hi there, >> >> >> >> I'm maintainer of vertica-python package and want to add support for >> >> python3, but I'm a little bit lost in naming. >> >> >> >> I named package as a upstream 'vertica-python', because (if I remember >> >> correctly) naming guidelines told, that if upstream has 'python' in >> >> the name it should stay there (can't found the source now). But how >> >> should I name python3 package? Should it be 'python3-vertica-python' >> >> od 'vertica-python3'? >> >> >> >> Or should I rename package to python{3,2}-vertica and obsolete >> >> vertica-python? >> >> >> >> >> > >> > Well the name in setup.py is vertica-python and it installs as >> > vertica_python and the pip install is that as well. >> > >> > So according to the guidelines I'd expect it to by >> > python2-vertica-python and python3-vertica-python even if it sounds a >> > little awkward, best way to handle anything that might end up >> > depending on it etc >> IMO this is worst thing. I think having pythonX-vertica is better. > > I just sniffed around repos and found just one package with a weird > name - it's python3-python-etcd. On the other hand I found a few, which > are in style <name>-python3, e.g. abrt-python3, libvirt-python3. So it > looks, that this naming should be quite good. > Those two examples are probably wrong: https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidel... Also you should read: https://fedoraproject.org/wiki/Packaging:Python according to that python{2,3}-vertica-python ought to be correct

On Wed, Dec 7, 2016 at 8:13 AM, James Hogarth <james.hogarth(a)gmail.com&gt; wrote: > On 7 December 2016 at 13:07, Jakub Jedelsky <jakub.jedelsky(a)gmail.com&gt; wrote: >> On Wed, Dec 07, 2016 at 11:48:55AM +0100, Igor Gnatenko wrote: >>> On Wed, Dec 7, 2016 at 10:48 AM, James Hogarth <james.hogarth(a)gmail.com&gt; wrote: >>>> On 7 December 2016 at 09:39, Jakub Jedelsky <jakub.jedelsky(a)gmail.com&gt; wrote: >>>>> Hi there, >>>>> >>>>> I'm maintainer of vertica-python package and want to add support for >>>>> python3, but I'm a little bit lost in naming. >>>>> >>>>> I named package as a upstream 'vertica-python', because (if I remember >>>>> correctly) naming guidelines told, that if upstream has 'python' in >>>>> the name it should stay there (can't found the source now). But how >>>>> should I name python3 package? Should it be 'python3-vertica-python' >>>>> od 'vertica-python3'? >>>>> >>>>> Or should I rename package to python{3,2}-vertica and obsolete >>>>> vertica-python? >>>>> >>>>> >>>> Well the name in setup.py is vertica-python and it installs as >>>> vertica_python and the pip install is that as well. >>>> >>>> So according to the guidelines I'd expect it to by >>>> python2-vertica-python and python3-vertica-python even if it sounds a >>>> little awkward, best way to handle anything that might end up >>>> depending on it etc >>> IMO this is worst thing. I think having pythonX-vertica is better. >> I just sniffed around repos and found just one package with a weird >> name - it's python3-python-etcd. On the other hand I found a few, which >> are in style <name>-python3, e.g. abrt-python3, libvirt-python3. So it >> looks, that this naming should be quite good. >> > > Those two examples are probably wrong: > > https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidel... > > Also you should read: > > https://fedoraproject.org/wiki/Packaging:Python > > according to that python{2,3}-vertica-python ought to be correct That should probably be slightly revisited, as now that we offer automatically generated Provides of the PyPI name with "python<pyver>dist(<modulename>)" form, we should start having a more consistent scheme for Python packages. Unless there's some kind of naming conflict, I'd call it pythonX-vertica.

On Wed, 2016-12-07 at 16:26 +0100, Vít Ondruch wrote: > Generally it is bad idea to differ from the name platform package > manager uses. The packages *must* by policy Provide python2-vertica-python and python3-vertica-python respectively, but they don't absolutely have to be named that way. The guidelines - by my reading - absolutely require that the source package name start with 'python-' and the binary package names start with 'python2-' and 'python3-' , but they leave a bit of flexibility for what comes after the -. They only say: "The package name should reflect the upstream name of the Python module, and should generally take into account the name of the module used when importing it in Python scripts." 'reflect the upstream name' is not as strict as 'be identical to the upstream name'. Dropping the repetition of 'python' seems to fit within the guidelines. However, 'vertica-python' and 'vertica-python3' are right out, they are entirely against the guidelines and those names should not be used. If this package is under review, the reviewer must reject those names.