12:26 p.m.
Hi,
In https://bodhi.fedoraproject.org/updates/FEDORA-2021-7558b7e7fc I
received a message from bodhi:
"""
This update's test gating status has been changed to 'failed'.
"""
However, no tests actually failed yet, and the gating status is
adjusted to "waiting" immediately after.
This is a regression from the recent change to enable test gating in
bodhi. I remember complaining on this list at the time the change was
implemented, but apparently nothing happened. Please revert all this
gating stuff until it can be done without leaving inaccurate comments
on the updates! I should not receive any emails telling me that tests
have failed unless some test has actually failed. Thanks.
Michael
1:49 p.m.
New subject: Incorrect bodhi message "This update's test gating status has
been changed to 'failed'."
On Thu 2 Sep 2021, 18:27 Michael Catanzaro, <mcatanzaro(a)gnome.org> wrote:
Hi,
In https://bodhi.fedoraproject.org/updates/FEDORA-2021-7558b7e7fc I
received a message from bodhi:
"""
This update's test gating status has been changed to 'failed'.
"""
However, no tests actually failed yet, and the gating status is
adjusted to "waiting" immediately after.
This is a regression from the recent change to enable test gating in
bodhi. I remember complaining on this list at the time the change was
implemented, but apparently nothing happened. Please revert all this
gating stuff until it can be done without leaving inaccurate comments
on the updates!
Gating is optional so it shouldn't be causing an issue directly for those
who haven't opted in
I should not receive any emails telling me that tests
have failed unless some test has actually failed.
Agreed, go ahead and file it as a bug on the Bodhi tracker and we can take
a look at it
Thanks.
Michael
_______________________________________________
devel mailing list -- devel(a)lists.fedoraproject.org
To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
1:54 p.m.
New subject: Incorrect bodhi message "This update's test gating status has
been changed to 'failed'."
On Thu, Sep 2 2021 at 07:49:29 PM +0100, Leigh Griffin
<lgriffin(a)redhat.com> wrote:
Gating is optional so it shouldn't be causing an issue directly
for
those who haven't opted in
I believe this is incorrect, it's now required for critical path
packages. Otherwise it wouldn't be running at all, because I don't
believe we've opted-in to anything. (If we had opted in, where would we
have configured that?)
> I should not receive any emails telling me that tests
> have failed unless some test has actually failed.
Agreed, go ahead and file it as a bug on the Bodhi tracker and we can
take a look at it
I think we have a bug report already, actually, but I just don't know
where it is. :/ I can report a new issue if nobody remembers where to
find the existing one.
2:37 p.m.
New subject: Incorrect bodhi message "This update's test gating status has
been changed to 'failed'."
On Thu, 2021-09-02 at 13:54 -0500, Michael Catanzaro wrote:
On Thu, Sep 2 2021 at 07:49:29 PM +0100, Leigh Griffin
<lgriffin(a)redhat.com> wrote:
> Gating is optional so it shouldn't be causing an issue directly for
> those who haven't opted in
I believe this is incorrect, it's now required for critical path
packages. Otherwise it wouldn't be running at all, because I don't
believe we've opted-in to anything. (If we had opted in, where would we
have configured that?)
Yes, that is right. There is now project-wide gating on openQA tests
for critpath updates.
> > I should not receive any emails telling me that tests
> > have failed unless some test has actually failed.
>
> Agreed, go ahead and file it as a bug on the Bodhi tracker and we can
> take a look at it
I think we have a bug report already, actually, but I just don't know
where it is. :/ I can report a new issue if nobody remembers where to
find the existing one.
I fixed the bug, months ago, when you first reported it:
https://github.com/fedora-infra/bodhi/pull/4221
but the PR has not been merged, because Bodhi's CI is broken, and no-
one who has the power to merge the PR despite the CI failure has done
so. See:
https://github.com/fedora-infra/bodhi/pull/4221#issuecomment-860011362
--
Adam Williamson
Fedora QA
IRC: adamw | Twitter: adamw_ha
https://www.happyassassin.net
3:07 p.m.
New subject: Incorrect bodhi message "This update's test gating status has
been changed to 'failed'."
On Thu, Sep 2, 2021 at 8:40 PM Adam Williamson <adamwill(a)fedoraproject.org>
wrote:
On Thu, 2021-09-02 at 13:54 -0500, Michael Catanzaro wrote:
> On Thu, Sep 2 2021 at 07:49:29 PM +0100, Leigh Griffin
> <lgriffin(a)redhat.com> wrote:
> > Gating is optional so it shouldn't be causing an issue directly for
> > those who haven't opted in
>
> I believe this is incorrect, it's now required for critical path
> packages. Otherwise it wouldn't be running at all, because I don't
> believe we've opted-in to anything. (If we had opted in, where would we
> have configured that?)
Yes, that is right. There is now project-wide gating on openQA tests
for critpath updates.
Ah today I learned something new! Apologies for misinformation.
>
> > > I should not receive any emails telling me that tests
> > > have failed unless some test has actually failed.
> >
> > Agreed, go ahead and file it as a bug on the Bodhi tracker and we can
> > take a look at it
>
> I think we have a bug report already, actually, but I just don't know
> where it is. :/ I can report a new issue if nobody remembers where to
> find the existing one.
I fixed the bug, months ago, when you first reported it:
https://github.com/fedora-infra/bodhi/pull/4221
but the PR has not been merged, because Bodhi's CI is broken, and no-
one who has the power to merge the PR despite the CI failure has done
so. See:
https://github.com/fedora-infra/bodhi/pull/4221#issuecomment-860011362
I have tagged the blocking bug for my team to take a look at tomorrow,
hopefully we can get these merged in.
--
Adam Williamson
Fedora QA
IRC: adamw | Twitter: adamw_ha
https://www.happyassassin.net
_______________________________________________
devel mailing list -- devel(a)lists.fedoraproject.org
To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
--
Leigh Griffin
Senior Engineering Manager
Red Hat Waterford <https://www.redhat.com/>
Communications House
Cork Road, Waterford City
lgriffin(a)redhat.com
M: +353877545162 IM: lgriffin
@redhatjobs <https://twitter.com/redhatjobs> redhatjobs
<https://www.facebook.com/redhatjobs> @redhatjobs
<https://instagram.com/redhatjobs>
<https://red.ht/sig>
3:11 p.m.
New subject: Incorrect bodhi message "This update's test gating status has
been changed to 'failed'."
On Thu, Sep 2, 2021 at 4:08 PM Leigh Griffin <lgriffin(a)redhat.com> wrote:
On Thu, Sep 2, 2021 at 8:40 PM Adam Williamson <adamwill(a)fedoraproject.org>
wrote:
> On Thu, 2021-09-02 at 13:54 -0500, Michael Catanzaro wrote:
> > On Thu, Sep 2 2021 at 07:49:29 PM +0100, Leigh Griffin
> > <lgriffin(a)redhat.com> wrote:
> > > Gating is optional so it shouldn't be causing an issue directly for
> > > those who haven't opted in
> >
> > I believe this is incorrect, it's now required for critical path
> > packages. Otherwise it wouldn't be running at all, because I don't
> > believe we've opted-in to anything. (If we had opted in, where would we
> > have configured that?)
>
> Yes, that is right. There is now project-wide gating on openQA tests
> for critpath updates.
>
Ah today I learned something new! Apologies for misinformation.
> >
> > > > I should not receive any emails telling me that tests
> > > > have failed unless some test has actually failed.
> > >
> > > Agreed, go ahead and file it as a bug on the Bodhi tracker and we can
> > > take a look at it
> >
> > I think we have a bug report already, actually, but I just don't know
> > where it is. :/ I can report a new issue if nobody remembers where to
> > find the existing one.
>
> I fixed the bug, months ago, when you first reported it:
> https://github.com/fedora-infra/bodhi/pull/4221
> but the PR has not been merged, because Bodhi's CI is broken, and no-
> one who has the power to merge the PR despite the CI failure has done
> so. See:
> https://github.com/fedora-infra/bodhi/pull/4221#issuecomment-860011362
I have tagged the blocking bug for my team to take a look at tomorrow,
hopefully we can get these merged in.
This has been an issue for me as well. I started work on trying to improve
the intelligence on triggering offline updates from PackageKit, but the PR
I submitted to propagate more data from Bodhi into updateinfo metadata
hasn't been merged despite being approved for months for similar reasons:
https://github.com/fedora-infra/bodhi/pull/4214
--
真実はいつも一つ！/ Always, there's only one truth!
3:54 p.m.
New subject: Incorrect bodhi message "This update's test gating status has
been changed to 'failed'."
On Thu, Sep 2, 2021 at 9:13 PM Neal Gompa <ngompa13(a)gmail.com> wrote:
On Thu, Sep 2, 2021 at 4:08 PM Leigh Griffin
<lgriffin(a)redhat.com> wrote:
>
>
> On Thu, Sep 2, 2021 at 8:40 PM Adam Williamson <
> adamwill(a)fedoraproject.org> wrote:
>
>> On Thu, 2021-09-02 at 13:54 -0500, Michael Catanzaro wrote:
>> > On Thu, Sep 2 2021 at 07:49:29 PM +0100, Leigh Griffin
>> > <lgriffin(a)redhat.com> wrote:
>> > > Gating is optional so it shouldn't be causing an issue directly
for
>> > > those who haven't opted in
>> >
>> > I believe this is incorrect, it's now required for critical path
>> > packages. Otherwise it wouldn't be running at all, because I don't
>> > believe we've opted-in to anything. (If we had opted in, where would
>> we
>> > have configured that?)
>>
>> Yes, that is right. There is now project-wide gating on openQA tests
>> for critpath updates.
>>
>
> Ah today I learned something new! Apologies for misinformation.
>
>> >
>> > > > I should not receive any emails telling me that tests
>> > > > have failed unless some test has actually failed.
>> > >
>> > > Agreed, go ahead and file it as a bug on the Bodhi tracker and we
>> can
>> > > take a look at it
>> >
>> > I think we have a bug report already, actually, but I just don't know
>> > where it is. :/ I can report a new issue if nobody remembers where to
>> > find the existing one.
>>
>> I fixed the bug, months ago, when you first reported it:
>> https://github.com/fedora-infra/bodhi/pull/4221
>> but the PR has not been merged, because Bodhi's CI is broken, and no-
>> one who has the power to merge the PR despite the CI failure has done
>> so. See:
>> https://github.com/fedora-infra/bodhi/pull/4221#issuecomment-860011362
>
>
> I have tagged the blocking bug for my team to take a look at tomorrow,
> hopefully we can get these merged in.
>
This has been an issue for me as well. I started work on trying to improve
the intelligence on triggering offline updates from PackageKit, but the PR
I submitted to propagate more data from Bodhi into updateinfo metadata
hasn't been merged despite being approved for months for similar reasons:
https://github.com/fedora-infra/bodhi/pull/4214
Thanks Neal, I added it to my list and have opened a dialog to get more
insights into the current state of Bodhi. I'd like to understand why there
is a bottleneck here from a merge permissions perspective. I will keep
folks posted.
--
真実はいつも一つ！/ Always, there's only one truth!
_______________________________________________
devel mailing list -- devel(a)lists.fedoraproject.org
To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
--
Leigh Griffin
Senior Engineering Manager
Red Hat Waterford <https://www.redhat.com/>
Communications House
Cork Road, Waterford City
lgriffin(a)redhat.com
M: +353877545162 IM: lgriffin
@redhatjobs <https://twitter.com/redhatjobs> redhatjobs
<https://www.facebook.com/redhatjobs> @redhatjobs
<https://instagram.com/redhatjobs>
<https://red.ht/sig>
974
days inactive
974
days old
6 comments
4 participants
participants (4)
-
Adam Williamson -
Leigh Griffin -
Michael Catanzaro -
Neal Gompa