8:48 a.m.
I have a project I''m trying to package which uses git submodules
extensively.
The fact that 'git archive' can't already deal with this amazes me but I
recently discovered the 'git submodule foreach' command which seemed to be
able to handle what I needed.
Or so I thought...
The foreach command only expands its internal variables with single ('')
quotes but of course bash variables only work with double ("") quotes.
Unless there's some serious security consideration, WHY would you make it
impossible to mix the internal and bash variables?!?!?!?
Here's part of the script I'm having issues with:
git submodule foreach --recursive 'git archive --verbose
--prefix=$prefix-$tag/$sm_path/ --format tar HEAD --output
$tempdir/$prefix-sub-$sha1.tar'
The $sm_path is the path to the submodule within the main git repository
which I need for proper archiving.
Any ideas?
Thanks,
Richard
9:12 a.m.
The solution was non-obvious but I finally found the hint I needed...
Escape the git internal variables, i.e.: \$sm_path so bash doesn't expand
them so they are still passed to 'git submodule foreach'
Thanks,
Richard
11:42 a.m.
On Sun, 2022-08-28 at 18:27 +0200, Vitaly Zaitsev via devel wrote:
On 28/08/2022 15:48, Richard Shaw wrote:
> I have a project I''m trying to package which uses git submodules
> extensively.
Just add all submodules as SourceX.
for example rawstudio.spec
https://src.fedoraproject.org/rpms/rawstudio//blob/rawhide/f/rawstudio.sp...
--
Sincerely,
Vitaly Zaitsev (vitaly(a)easycoding.org)
_______________________________________________
devel mailing list -- devel(a)lists.fedoraproject.org
To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
--
Sérgio M. B.
11:48 a.m.
On Sun, Aug 28, 2022 at 11:28 AM Vitaly Zaitsev via devel <
devel(a)lists.fedoraproject.org> wrote:
On 28/08/2022 15:48, Richard Shaw wrote:
> I have a project I''m trying to package which uses git submodules
> extensively.
Just add all submodules as SourceX.
I may have to do that, but there's 18 of them... Bah, what a pain in the...
I actually have my script nearly 100% working but apparently there's an
unfixed bug in tar found in 2008 that if you try to concatenate multiple
archives it doesn't do it correctly and you end up getting masked files.
For posterity here's my *ALMOST* working script...
https://hobbes1069.fedorapeople.org/git-archive-all
Thanks,
Richard
12:22 p.m.
On Sun, 2022-08-28 at 11:48 -0500, Richard Shaw wrote:
I may have to do that, but there's 18 of them... Bah, what a pain
in
the...
I actually have my script nearly 100% working but apparently there's
an
unfixed bug in tar found in 2008 that if you try to concatenate
multiple
archives it doesn't do it correctly and you end up getting masked
files.
For posterity here's my *ALMOST* working script...
I ran into this issue years ago. git-build-rpm handles submodules. git-
archive-all IIRC is also an existing pip package. I filed a bug report
a long time ago for rpkg to have submodule support, so it may have
already been added.
11:50 a.m.
On Sun, 2022-08-28 at 08:48 -0500, Richard Shaw wrote:
I have a project I''m trying to package which uses git
submodules
extensively.
maybe the best is you create all source code in one tar.gz with git
fetch all submodules (I don't remember the command right now) and with
tar cvf create the source.tar.gz
--
Sérgio M. B.
11:55 a.m.
On Sun, 2022-08-28 at 17:50 +0100, Sérgio Basto wrote:
On Sun, 2022-08-28 at 08:48 -0500, Richard Shaw wrote:
> I have a project I''m trying to package which uses git submodules
> extensively.
maybe the best is you create all source code in one tar.gz with git
fetch all submodules (I don't remember the command right now) and
with tar cvf create the source.tar.gz
https://stackoverflow.com/questions/16773642/pull-git-submodules-after-cl...
I'd say `git submodule update --init`
_______________________________________________
devel mailing list -- devel(a)lists.fedoraproject.org
To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproj
ect.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
--
Sérgio M. B.
12:15 p.m.
On Sun, Aug 28, 2022 at 11:56 AM Sérgio Basto <sergio(a)serjux.com> wrote:
On Sun, 2022-08-28 at 17:50 +0100, Sérgio Basto wrote:
On Sun, 2022-08-28 at 08:48 -0500, Richard Shaw wrote:
I have a project I''m trying to package which uses git submodules
extensively.
maybe the best is you create all source code in one tar.gz with git fetch
all submodules (I don't remember the command right now) and with tar cvf
create the source.tar.gz
https://stackoverflow.com/questions/16773642/pull-git-submodules-after-cl...
I'd say `git submodule update --init`
I don't think that's quite what I'm looking for... I have it all checked
out, but git archive doesn't traverse submodules, that led me to the git
submodule foreach option. I have it all exporting but the tar bug is
preventing me from properly re-archiving it...
$ ll /tmp/nanomq-Giy3f1/
total 285048
-rw-r--r--. 1 build build 9113600 Aug 28 11:26 nanomq-0.11.0.tar
-rw-r--r--. 1 build build 27115520 Aug 28 11:26
nanomq-sub-2070f8ad9151dc8f3a73bffaa146b5e6937a583f.tar
-rw-r--r--. 1 build build 36024320 Aug 28 11:26
nanomq-sub-2196000605e45d91097147c9c71f26b72af58003.tar
-rw-r--r--. 1 build build 61440 Aug 28 11:26
nanomq-sub-25647e692c7906b96ffd2b05ca54c097948e879c.tar
-rw-r--r--. 1 build build 81920 Aug 28 11:26
nanomq-sub-288d545b92720e3fc38df400419a043cfadb840b.tar
-rw-r--r--. 1 build build 4157440 Aug 28 11:26
nanomq-sub-7274ec186442c96e4c7dcc99c684a03e5db2ff48.tar
-rw-r--r--. 1 build build 24586240 Aug 28 11:26
nanomq-sub-81a252c381a022cec2b5dd2b048b1b5fb86adee8.tar
-rw-r--r--. 1 build build 26716160 Aug 28 11:26
nanomq-sub-890ca2f401924cdcb88f493950b04700bbe52db3.tar
-rw-r--r--. 1 build build 14264320 Aug 28 11:26
nanomq-sub-92d7fbdcbeb120b657f965286e4e60b59782b631.tar
-rw-r--r--. 1 build build 1361920 Aug 28 11:26
nanomq-sub-93bd57cb79d0ef72fe0a6a4cfeb68a8f2d1570bc.tar
-rw-r--r--. 1 build build 491520 Aug 28 11:26
nanomq-sub-a4f472c5fe2c8298c0ada2e24717458c45a17eb1.tar
-rw-r--r--. 1 build build 645120 Aug 28 11:26
nanomq-sub-ae65120919222692672c65c43e4ca0a7198680f3.tar
-rw-r--r--. 1 build build 450560 Aug 28 11:26
nanomq-sub-b6a337311ec3bbc5603fa2ce541850a603844e58.tar
-rw-r--r--. 1 build build 102400 Aug 28 11:26
nanomq-sub-cce300734bfe5c3879b0449ac283a872633e615c.tar
-rw-r--r--. 1 build build 20510720 Aug 28 11:26
nanomq-sub-d65aeb37349ad1a50e0f6c9b694d4b5290d60e49.tar
-rw-r--r--. 1 build build 532480 Aug 28 11:26
nanomq-sub-edaf364899b3e95ecb892c61f216822baed80346.tar
-rw-r--r--. 1 build build 44083200 Aug 28 11:26
nanomq-sub-f105ac0bfdae1ce009b8fd86bc6d9f65e5576352.tar
-rw-r--r--. 1 build build 1894400 Aug 28 11:26
nanomq-sub-f2e8a41aed75b001d23316981e8afa3e4b5801a2.tar
-rw-r--r--. 1 build build 79677440 Aug 28 11:26
nanomq-sub-fa84d185c0fefa7d612759e02a26def2f948fe34.tar
I tried a for loop to concatenate each archive individually (as seen in the
script I posted earlier) instead of all at once but it didn't help.
Unless someone has a better solution, I guess I'll just expand all the tar
files and reachrive some scratch.
Thanks,
Richard
3:10 p.m.
On Sun, Aug 28, 2022 at 12:47 PM Maxwell G via devel <
devel(a)lists.fedoraproject.org> wrote:
Aug 28, 2022 12:17:25 PM Richard Shaw <hobbes1069(a)gmail.com>:
> but git archive doesn't traverse submodules,
I think Sérgio was saying to create the archive using tar, *instead of*
git archive.
Ahh, but that would include the whole tree / commit history / everything,
right? Not just the version/tag I want.
Thanks,
Richard
3:26 p.m.
On Sunday, August 28, 2022 Richard Shaw wrote:
Ahh, but that would include the whole tree / commit history /
everything,
right? Not just the version/tag I want.
You can exclude the .git directories from
the archive. See in particular tar's "--exclude-vcs" option.
--
Thanks,
Maxwell G (@gotmax23)
Pronouns: He/Him/His
8:10 a.m.
On Sun, 2022-08-28 at 15:10 -0500, Richard Shaw wrote:
On Sun, Aug 28, 2022 at 12:47 PM Maxwell G via devel <
devel(a)lists.fedoraproject.org> wrote:
>
> Aug 28, 2022 12:17:25 PM Richard Shaw <hobbes1069(a)gmail.com>:
>
> > but git archive doesn't traverse submodules,
> I think Sérgio was saying to create the archive using tar, *instead of*
> git archive.
>
Ahh, but that would include the whole tree / commit history / everything,
right? Not just the version/tag I want.
For release purposes I always use make dist (or make distcheck where
possible).
I find git archive generally suboptimal for that task.
Simo.
--
Simo Sorce
RHEL Crypto Team
Red Hat, Inc
645
days inactive
646
days old
13 comments
6 participants
participants (6)
-
Maxwell G -
remyabel -
Richard Shaw -
Simo Sorce -
Sérgio Basto -
Vitaly Zaitsev