On 2018-11-04 11:21 a.m., Nicolas Mailhot wrote:
Le dimanche 04 novembre 2018 à 11:01 -0800, Luya Tshimbalanga a écrit
:
> On 2018-11-04 4:43 a.m., Nicolas Mailhot wrote:
>> So, basically you should just need a do2unix and the following lines
>> in
>> rawhide:
> I have Fedora 29 installed and the above line still led to error.
Which error please?
$ rpmspec -P luxcorerender.spec
'orgemeta: invalid option -- '
in forgemeta(az:sviu:)
error: line 10: %forgemeta -a
$ dos2unix luxcorerender.spec
dos2unix: converting file luxcorerender.spec to Unix format...
$ rpmspec -P luxcorerender.spec
Name: luxcorerender
Version: 2.1
…
Yes that error. I haven't used rpmspec command before. Very useful.
> Maybe
> porting redhat-rpm-macro to the current release will alleviate the
> issue.
If you have the above error that’s due to the DOS end of lines in your
spec file.
Otherwise, as I said, you need devel (a Fedora version with redhat-rpm-
config 123 or a later version) for forgemeta to understand multiple
archives.
Noted. That resolved the problem.
>> Name: luxcorerender
>> Version: 2.1
>> %global prerelease beta1
>> %global forgeurl0
https://github.com/%{name}/LuxCore
>> %global tag0 luxcorerender_v%{version}%{?prerelease}
>>
>> %global forgeurl1
https://github.com/%{name}/BlendLuxCore
>> %global tag1 blendluxcore_v%{version}%{?prerelease}
>>
>> %forgemeta -a
>>
>> […]
That line generated an error using rpmbuild -bs command on Fedora 29.
It
looks like the tool needs upgrade as well.
>>
>> Source0: %{forgesource0}
>> Source1: %{forgesource1}
>>
>> […]
>>
>> %prep
>> %forgesetup -a
>> %patch0 -pX
> Will it be better to put "%forgesetup -a -pX" in one line similar to
> "%autosetup" considering this scenario?
Really, no. You can unpack several archives at once (with -a) or unpack
one at a time with patching (with forgeautosetup -z <number>) but rpm
macro argument parsing is not up to doing both at once safely. %setup
does not use normal rpm argument parsing, that's why it sort of works.
And, besides, the result would probably be unmaintainable cryptic macro
calls.
Regards,
Thank you for the explanation.
I submitted the spec for re-review on
https://bugzilla.redhat.com/show_bug.cgi?id=1645913. I'll update shortly
with the newer version.
Luya