Today I tried reviewing some Python packages:
- x-tile:
https://bugzilla.redhat.com/show_bug.cgi?id=1861020
- python-iptools:
https://bugzilla.redhat.com/show_bug.cgi?id=1870907
And the mock build done by fedora-review failed. The error message I got was:
line XX: fg: no job control
Which means that RPM didn't
recognize the "%py3_build" macro and left it as-is, so bash then saw
"%" and tried to do job control and failed.
I checked the logs for both failed reviews, and looking at root.log, neither review
installed python3-rpm-macros, which is where "%py3_build" and
"%py3_install" come from. Now, looking at python3.9.spec, there's this bit:
Requires: (python3-rpm-macros if rpm-build)
So right now I'm inclined to think that maybe when fedora-review calls mock, and mock
installs BuildRequires, it doesn't install them in the rpm-build context? This would
explain both the Python and the C/C++ failures, since like python3-rpm-macros, annobin
isn't required for "user" builds, but is used for RPM builds.