Hi all, I would like to ask as Vim co-maintainer, do you find useful for Vim to do: - when you open new file with .spec suffix, Vim will get you basic spec file structure? Recently I found out someone can find it as bad behavior https://bugzilla.redhat.com/show_bug.cgi?id=1724126 , so I consider changing the default vimrc to tell Vim 'Don't do it'. What's your opinion? Is it useful feature of Vim and it should stay as default, or it needs to be disabled?

On 7/18/19 7:44 AM, Zdenek Dohnal wrote: > Hi all, > > I would like to ask as Vim co-maintainer, do you find useful for Vim to do: > > - when you open new file with .spec suffix, Vim will get you basic spec > file structure? > > Recently I found out someone can find it as bad behavior > https://bugzilla.redhat.com/show_bug.cgi?id=1724126 , so I consider > changing the default vimrc to tell Vim 'Don't do it'. > > What's your opinion? Is it useful feature of Vim and it should stay as > default, or it needs to be disabled? I've never had a problem with it, but then I only edit rpm spec files. If you were to remove it from /etc/vimrc, would the normal syntax system still provide a good way to edit rpm spec files?

Steve _______________________________________________ devel mailing list -- devel(a)lists.fedoraproject.org To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Hello, Zdenek Dohnal. Thu, 18 Jul 2019 13:44:56 +0200 you wrote: > What's your opinion? Is it useful feature of Vim and it should stay as > default, or it needs to be disabled? I think, that *.spec files on Fedora should be treated as RPM SPEC files by default.

-- Sincerely, Vitaly Zaitsev (vitaly(a)easycoding.org) _______________________________________________ devel mailing list -- devel(a)lists.fedoraproject.org To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Even the new .spec files, which do not have to be RPM spec files? Because Vim provides spec template for such cases.

On 7/18/19 4:10 PM, Vitaly Zaitsev via devel wrote: > Hello, Zdenek Dohnal. > > Thu, 18 Jul 2019 15:51:33 +0200 you wrote: > >> Even the new .spec files, which do not have to be RPM spec files? >> Because Vim provides spec template for such cases. > I never used this feature, so I think it can be disabled by default. That's the thing which I asked for opinion on, not about syntax highlighting.

We also have rpmdev-newspec

>>>>> "ZD" == Zdenek Dohnal <zdohnal(a)redhat.com&gt; writes: ZD> Hi all, I would like to ask as Vim co-maintainer, do you find useful ZD> for Vim to do: ZD> - when you open new file with .spec suffix, Vim will get you basic ZD> spec file structure? Personally I have always found that behavior annoying. If I open a new file, I expect that the file would be empty. If I want a template, I can copy one. Editing a new HTML file doesn't bring up a template for HTML files, for example. The spec template used isn't something I ever want anyway. It uses tabs instead of spaces and uses them in a way that implies that indentation is somehow required.

And it includes a default release tag of "0%{?dist}" which isn't permitted by the packaging guidelines.

(Releases start at one except when packaging prerelease software, and are never exactly zero.) Best to leave it to the packager to choose their own template, or to allow somehow who wants templating behavior to configure templating in a general way. - J<

On Fri, 19 Jul 2019 at 05:09, Zdenek Dohnal <zdohnal(a)redhat.com&gt; wrote: > > > On 7/18/19 9:47 PM, Jason L Tibbitts III wrote: >>>>>>> "ZD" == Zdenek Dohnal <zdohnal(a)redhat.com&gt; writes: >> ZD> Hi all, I would like to ask as Vim co-maintainer, do you find useful >> ZD> for Vim to do: >> >> ZD> - when you open new file with .spec suffix, Vim will get you basic >> ZD> spec file structure? >> >> Personally I have always found that behavior annoying. If I open a new >> file, I expect that the file would be empty. If I want a template, I >> can copy one. Editing a new HTML file doesn't bring up a template for >> HTML files, for example. >> >> The spec template used isn't something I ever want anyway. It uses tabs >> instead of spaces and uses them in a way that implies that indentation >> is somehow required. > Converted to spaces now. >> And it includes a default release tag of >> "0%{?dist}" which isn't permitted by the packaging guidelines. > Expected. It is designed for user to run rpmdev-bumpspec <package>.spec, > so the tool will supply correct format of changelog entry and increment > the release. Why would you use rpmdev-bumpspec for a file created in vim when you can use <leader>c in vim directly?

Hi all, I would like to ask as Vim co-maintainer, do you find useful for Vim to do: - when you open new file with .spec suffix, Vim will get you basic spec file structure? Recently I found out someone can find it as bad behavior https://bugzilla.redhat.com/show_bug.cgi?id=1724126 , so I consider changing the default vimrc to tell Vim 'Don't do it'. What's your opinion? Is it useful feature of Vim and it should stay as default, or it needs to be disabled? _______________________________________________ devel mailing list -- devel(a)lists.fedoraproject.org To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org