Hi To update to the current version of mkdocs, I'd need these four dependencies reviewed: - python-mkdocs-redirects: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000347 - python-pyyaml_env_tag: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000348 - python-ghp-import: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000349 - python-mergedeep: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000350 All are simple python packages. Happy to review in exchange.

On 02.09.21 02:13, Miro Hrončok wrote: > On 02. 09. 21 0:51, Sandro Mani wrote: >> Hi >> >> To update to the current version of mkdocs, I'd need these four dependencies >> reviewed: >> >> - python-mkdocs-redirects: >> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000347 >> - python-pyyaml_env_tag: >> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000348 >> - python-ghp-import: >> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000349 >> - python-mergedeep: >> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000350 >> >> All are simple python packages. >> >> Happy to review in exchange. > > If you use the new Python macros/guidelines, I will gladly review the > packages, no need to review packages in exchange. > > https://fedoraproject.org/wiki/Changes/PythonPackagingGuidelines202x > > Read this as my extended offer to review any package that uses the new Python > macros as long as I am technically able to. > Hmm in the case of python-pyyaml_env_tag, using [...] %prep %autosetup -p1 -n %{srcname}-%{version} %generate_buildrequires %pyproject_buildrequires -t %build %pyproject_wheel %install %pyproject_install %pyproject_save_files %{srcname} %check %pytest [...] I get [...] ERROR: tox config file (either pyproject.toml, tox.ini, setup.cfg) not found [...] But there is a pyproject.toml file in the source archive. Any ideas how to debug this? FWIW, this is the src.rpm: https://smani.fedorapeople.org/review/python-pyyaml_env_tag-0.1-2.fc36.sr...

On 02.09.21 11:16, Miro Hrončok wrote: > On 02. 09. 21 10:14, Sandro Mani wrote: >> On 02.09.21 02:13, Miro Hrončok wrote: >>> On 02. 09. 21 0:51, Sandro Mani wrote: >>>> Hi >>>> >>>> To update to the current version of mkdocs, I'd need these four >>>> dependencies reviewed: >>>> >>>> - python-mkdocs-redirects: >>>> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000347 >>>> - python-pyyaml_env_tag: >>>> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000348 >>>> - python-ghp-import: >>>> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000349 >>>> - python-mergedeep: >>>> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000350 >>>> >>>> All are simple python packages. >>>> >>>> Happy to review in exchange. >>> >>> If you use the new Python macros/guidelines, I will gladly review the >>> packages, no need to review packages in exchange. >>> >>> https://fedoraproject.org/wiki/Changes/PythonPackagingGuidelines202x >>> >>> Read this as my extended offer to review any package that uses the new >>> Python macros as long as I am technically able to. >>> >> Hmm in the case of python-pyyaml_env_tag, using >> >> [...] >> >> %prep %autosetup -p1 -n %{srcname}-%{version} %generate_buildrequires >> %pyproject_buildrequires -t %build %pyproject_wheel %install >> %pyproject_install %pyproject_save_files %{srcname} %check %pytest >> >> [...] >> >> I get >> >> [...] ERROR: tox config file (either pyproject.toml, tox.ini, setup.cfg) not >> found [...] >> >> But there is a pyproject.toml file in the source archive. Any ideas how to >> debug this? FWIW, this is the src.rpm: >> https://smani.fedorapeople.org/review/python-pyyaml_env_tag-0.1-2.fc36.sr... > > I see that the tox error wording is a tad confusing. > pyproject.toml is there, but there is no tox configuration in it. > It seems that upstream does not use tox, so neither can downstream. > So how can I make %pyproject_wheel use setup.py? Delete the pyproject.toml file?

On 02. 09. 21 11:33, Miro Hrončok wrote: > On 02. 09. 21 11:31, Sandro Mani wrote: >> >> On 02.09.21 11:16, Miro Hrončok wrote: >>> On 02. 09. 21 10:14, Sandro Mani wrote: >>>> On 02.09.21 02:13, Miro Hrončok wrote: >>>>> On 02. 09. 21 0:51, Sandro Mani wrote: >>>>>> Hi >>>>>> >>>>>> To update to the current version of mkdocs, I'd need these four >>>>>> dependencies reviewed: >>>>>> >>>>>> - python-mkdocs-redirects: >>>>>> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000347 >>>>>> - python-pyyaml_env_tag: >>>>>> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000348 >>>>>> - python-ghp-import: >>>>>> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000349 >>>>>> - python-mergedeep: >>>>>> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000350 >>>>>> >>>>>> All are simple python packages. >>>>>> >>>>>> Happy to review in exchange. >>>>> >>>>> If you use the new Python macros/guidelines, I will gladly review >>>>> the packages, no need to review packages in exchange. >>>>> >>>>> https://fedoraproject.org/wiki/Changes/PythonPackagingGuidelines202x >>>>> >>>>> Read this as my extended offer to review any package that uses >>>>> the new Python macros as long as I am technically able to. >>>>> >>>> Hmm in the case of python-pyyaml_env_tag, using >>>> >>>> [...] >>>> >>>> %prep %autosetup -p1 -n %{srcname}-%{version} >>>> %generate_buildrequires %pyproject_buildrequires -t %build >>>> %pyproject_wheel %install %pyproject_install %pyproject_save_files >>>> %{srcname} %check %pytest >>>> >>>> [...] >>>> >>>> I get >>>> >>>> [...] ERROR: tox config file (either pyproject.toml, tox.ini, >>>> setup.cfg) not found [...] >>>> >>>> But there is a pyproject.toml file in the source archive. Any >>>> ideas how to debug this? FWIW, this is the src.rpm: >>>> https://smani.fedorapeople.org/review/python-pyyaml_env_tag-0.1-2.fc36.sr... >>> >>> I see that the tox error wording is a tad confusing. >>> pyproject.toml is there, but there is no tox configuration in it. >>> It seems that upstream does not use tox, so neither can downstream. >>> >> So how can I make %pyproject_wheel use setup.py? Delete the >> pyproject.toml file? > > pyproject.toml sets peotry as build backend, not setuptools -- there > is no need to use setup.py?. To avoid the error, don't use the -t > (tox) option for %pyproject_buildrequires. I've meant flit, not peotry. Here is a spec file that works: https://churchyard.fedorapeople.org/SRPMS/python-pyyaml-env-tag.spec

On 02. 09. 21 0:51, Sandro Mani wrote: > Hi > > To update to the current version of mkdocs, I'd need these four > dependencies reviewed: > > - python-mkdocs-redirects: > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000347 > - python-pyyaml_env_tag: > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000348 > - python-ghp-import: > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000349 > - python-mergedeep: > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2000350 > > All are simple python packages. > > Happy to review in exchange. If you use the new Python macros/guidelines, I will gladly review the packages, no need to review packages in exchange. https://fedoraproject.org/wiki/Changes/PythonPackagingGuidelines202x Read this as my extended offer to review any package that uses the new Python macros as long as I am technically able to.